From: Joel Brobecker <brobecker@adacore.com>
To: Lukas Durfina <ldurfina@tachyum.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] Fix compilation error with musl in gdb/testsuite/gdb.base/fileio.c
Date: Mon, 03 Feb 2020 10:37:00 -0000 [thread overview]
Message-ID: <20200203103728.GA30087@adacore.com> (raw)
In-Reply-To: <20200203101011.22560-1-ldurfina@tachyum.com>
> Musl is giving warnings about these includes in this way:
> warning: #warning redirecting incorrect #include <sys/errno.h> to <errno.h>
> warning: #warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h>
>
> gdb/testsuite/Changelog:
>
> * gdb.base/fileio.c: Remove #include of <sys/errno.h>.
> Replace #include of <sys/fcntl.h> by <fcntl.h>.
Thank you; pushed to master, under the "tiny change" rule.
> ---
> gdb/testsuite/ChangeLog | 5 +++++
> gdb/testsuite/gdb.base/fileio.c | 3 +--
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
> index b5ba5ba59d..9fd6cea172 100644
> --- a/gdb/testsuite/ChangeLog
> +++ b/gdb/testsuite/ChangeLog
> @@ -1,3 +1,8 @@
> +2020-02-03 Lukas Durfina <ldurfina@tachyum.com>
> +
> + * gdb.base/fileio.c: Remove #include of <sys/errno.h>.
> + Replace #include of <sys/fcntl.h> by <fcntl.h>.
> +
> 2020-02-01 Tom de Vries <tdevries@suse.de>
>
> * gdb.server/server-kill-python.exp: Fix $gdb_tst_name typo.
> diff --git a/gdb/testsuite/gdb.base/fileio.c b/gdb/testsuite/gdb.base/fileio.c
> index 7f482a34d3..0f201518b7 100644
> --- a/gdb/testsuite/gdb.base/fileio.c
> +++ b/gdb/testsuite/gdb.base/fileio.c
> @@ -1,13 +1,12 @@
> #include <stdio.h>
> #include <stdlib.h>
> #include <string.h>
> -#include <sys/errno.h>
> #include <sys/types.h>
> -#include <sys/fcntl.h>
> #include <sys/stat.h>
> #include <sys/time.h>
> #include <errno.h>
> #include <sys/wait.h>
> +#include <fcntl.h>
> #include <unistd.h>
> #include <time.h>
> /* TESTS :
> --
> 2.17.1
--
Joel
prev parent reply other threads:[~2020-02-03 10:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 14:47 [PATCH] gdb/testsuite: Updated includes Lukas Durfina
2020-01-05 6:25 ` Joel Brobecker
2020-01-07 13:48 ` Lukas Durfina
2020-01-07 17:55 ` Joel Brobecker
2020-01-09 8:17 ` Lukas Durfina
2020-02-01 10:15 ` Joel Brobecker
2020-02-03 10:00 ` Lukas Durfina
2020-02-03 10:25 ` Joel Brobecker
2020-02-03 10:10 ` [PATCH] [gdb/testsuite] Fix compilation error with musl in gdb/testsuite/gdb.base/fileio.c Lukas Durfina
2020-02-03 10:37 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203103728.GA30087@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=ldurfina@tachyum.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox