From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-163738-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 36496 invoked by alias); 3 Feb 2020 10:37:35 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 36484 invoked by uid 89); 3 Feb 2020 10:37:35 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-18.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1667
X-HELO: rock.gnat.com
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Feb 2020 10:37:34 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id A21AC117B7C;	Mon,  3 Feb 2020 05:37:32 -0500 (EST)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id CxV9KUUVMLO5; Mon,  3 Feb 2020 05:37:32 -0500 (EST)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1])	by rock.gnat.com (Postfix) with ESMTP id 3FA14117B3E;	Mon,  3 Feb 2020 05:37:32 -0500 (EST)
Received: by joel.gnat.com (Postfix, from userid 1000)	id 1A13C83AF9; Mon,  3 Feb 2020 14:37:28 +0400 (+04)
Date: Mon, 03 Feb 2020 10:37:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Lukas Durfina <ldurfina@tachyum.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] Fix compilation error with musl in gdb/testsuite/gdb.base/fileio.c
Message-ID: <20200203103728.GA30087@adacore.com>
References: <20200201101548.GA19442@adacore.com> <20200203101011.22560-1-ldurfina@tachyum.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200203101011.22560-1-ldurfina@tachyum.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
X-SW-Source: 2020-02/txt/msg00040.txt.bz2

> Musl is giving warnings about these includes in this way:
> warning: #warning redirecting incorrect #include <sys/errno.h> to <errno.h>
> warning: #warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h>
> 
> gdb/testsuite/Changelog:
> 
> 	* gdb.base/fileio.c: Remove #include of <sys/errno.h>.
> 	Replace #include of <sys/fcntl.h> by <fcntl.h>.

Thank you; pushed to master, under the "tiny change" rule.

> ---
>  gdb/testsuite/ChangeLog         | 5 +++++
>  gdb/testsuite/gdb.base/fileio.c | 3 +--
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
> index b5ba5ba59d..9fd6cea172 100644
> --- a/gdb/testsuite/ChangeLog
> +++ b/gdb/testsuite/ChangeLog
> @@ -1,3 +1,8 @@
> +2020-02-03  Lukas Durfina  <ldurfina@tachyum.com>
> +
> +	* gdb.base/fileio.c: Remove #include of <sys/errno.h>.
> +	Replace #include of <sys/fcntl.h> by <fcntl.h>.
> +
>  2020-02-01  Tom de Vries  <tdevries@suse.de>
>  
>  	* gdb.server/server-kill-python.exp: Fix $gdb_tst_name typo.
> diff --git a/gdb/testsuite/gdb.base/fileio.c b/gdb/testsuite/gdb.base/fileio.c
> index 7f482a34d3..0f201518b7 100644
> --- a/gdb/testsuite/gdb.base/fileio.c
> +++ b/gdb/testsuite/gdb.base/fileio.c
> @@ -1,13 +1,12 @@
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <string.h>
> -#include <sys/errno.h>
>  #include <sys/types.h>
> -#include <sys/fcntl.h>
>  #include <sys/stat.h>
>  #include <sys/time.h>
>  #include <errno.h>
>  #include <sys/wait.h>
> +#include <fcntl.h>
>  #include <unistd.h>
>  #include <time.h>
>  /* TESTS :
> -- 
> 2.17.1

-- 
Joel