From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57366 invoked by alias); 5 Jan 2020 06:25:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57356 invoked by uid 89); 5 Jan 2020 06:25:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=berndedlingerhotmailde, U*bernd.edlinger, Bernd, bernd.edlinger@hotmail.de X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 05 Jan 2020 06:25:48 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 08161117203; Sun, 5 Jan 2020 01:25:47 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 2sfIvdEOOg3U; Sun, 5 Jan 2020 01:25:46 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 8F42B1171FD; Sun, 5 Jan 2020 01:25:46 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 26161838B8; Sun, 5 Jan 2020 10:25:42 +0400 (+04) Date: Sun, 05 Jan 2020 06:25:00 -0000 From: Joel Brobecker To: Lukas Durfina Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: Updated includes Message-ID: <20200105062542.GB12588@adacore.com> References: <20200102144714.93956-1-ldurfina@tachyum.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200102144714.93956-1-ldurfina@tachyum.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2020-01/txt/msg00092.txt.bz2 Hi Lukas, > Fixed compilation error with musl. Thanks for the patch! > --- > gdb/testsuite/ChangeLog | 4 ++++ > gdb/testsuite/gdb.base/fileio.c | 3 +-- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog > index f7835f35f7..89d403897c 100644 > --- a/gdb/testsuite/ChangeLog > +++ b/gdb/testsuite/ChangeLog > @@ -1,3 +1,7 @@ > +2020-01-02 Lukas Durfina > + > + * gdb.base/fileio.c: Updated includes to be more generic. For the revision log, I think it's import to be a bit more specific when explaining what changes you made and why. I see you removed the #include without replacing it by a #include of . However, this file does make references to errno, so I think there is an oversight there. Also, I see you not only replace by , but you also move its include further down. Any reason for that. Was it to move that include outside of the range of #include-s that include files in "sys"? For the ChangeLog, I think it is worth being a little more specific. For instance, I would have written the ChangeLog as follow: * gdb.base/fileio.c: Remove #include of . Replace #include of by . I'm usually the first in line to take shortcuts with ChangeLog files, but I try to be more informative when the cost of being so is so small... > + > 2019-12-29 Bernd Edlinger > > * gdb.base/line65535.exp: New file. > diff --git a/gdb/testsuite/gdb.base/fileio.c b/gdb/testsuite/gdb.base/fileio.c > index 7f482a34d3..0f201518b7 100644 > --- a/gdb/testsuite/gdb.base/fileio.c > +++ b/gdb/testsuite/gdb.base/fileio.c > @@ -1,13 +1,12 @@ > #include > #include > #include > -#include > #include > -#include > #include > #include > #include > #include > +#include > #include > #include > /* TESTS : > -- > 2.17.1 -- Joel