From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34374 invoked by alias); 7 Jan 2020 17:55:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34361 invoked by uid 89); 7 Jan 2020 17:55:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=duh, french, you! X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 07 Jan 2020 17:55:04 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D4050117484; Tue, 7 Jan 2020 12:55:02 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qTcdS9MmASpS; Tue, 7 Jan 2020 12:55:02 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 635F611716E; Tue, 7 Jan 2020 12:55:02 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 3345C863E5; Tue, 7 Jan 2020 21:54:58 +0400 (+04) Date: Tue, 07 Jan 2020 17:55:00 -0000 From: Joel Brobecker To: Lukas Durfina Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH] gdb/testsuite: Updated includes Message-ID: <20200107175458.GA31232@adacore.com> References: <20200102144714.93956-1-ldurfina@tachyum.com> <20200105062542.GB12588@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2020-01/txt/msg00151.txt.bz2 > > I see you removed the #include without replacing it by a > > #include of . However, this file does make references to errno, so I > > think there is an oversight there. > > There is already #include a few lines below, so I skipped it. Duh (head slap). but of course. Sorry. > > Also, I see you not only replace by , but you also move > > its include further down. Any reason for that. > > Was it to move that include outside of the range of #include-s that include > > files in "sys"? > > Exactly. My intention was to move it out of includes. No > other reason. > > > > > For the ChangeLog, I think it is worth being a little more specific. > > For instance, I would have written the ChangeLog as follow: > > > > * gdb.base/fileio.c: Remove #include of . > > Replace #include of by . > > > > I'm usually the first in line to take shortcuts with ChangeLog > > files, but I try to be more informative when the cost of being so is > > so small... > > I see your point. Is it fine to send the patch with updated Changelog? That would be fine. On the other hand, if you want, you can push the patch with the ChangeLog above, since the change itself looks good to me, now. Thank you! > > Lukas > > > > > > + > > > 2019-12-29 Bernd Edlinger > > > > > > * gdb.base/line65535.exp: New file. > > > diff --git a/gdb/testsuite/gdb.base/fileio.c > > > b/gdb/testsuite/gdb.base/fileio.c index 7f482a34d3..0f201518b7 100644 > > > --- a/gdb/testsuite/gdb.base/fileio.c > > > +++ b/gdb/testsuite/gdb.base/fileio.c > > > @@ -1,13 +1,12 @@ > > > #include > > > #include > > > #include > > > -#include > > > #include > > > -#include > > > #include > > > #include > > > #include > > > #include > > > +#include > > > #include > > > #include > > > /* TESTS : > > > -- > > > 2.17.1 > > > > -- > > Joel -- Joel