From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92158 invoked by alias); 1 Feb 2020 10:15:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92150 invoked by uid 89); 1 Feb 2020 10:15:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=doublechecking, double-checking, opportunity, you! X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 01 Feb 2020 10:15:54 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1032011794A; Sat, 1 Feb 2020 05:15:53 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id cwz+YQvCbu3i; Sat, 1 Feb 2020 05:15:53 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9A21911793E; Sat, 1 Feb 2020 05:15:52 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 19B9D82C47; Sat, 1 Feb 2020 14:15:48 +0400 (+04) Date: Sat, 01 Feb 2020 10:15:00 -0000 From: Joel Brobecker To: Lukas Durfina Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: Updated includes Message-ID: <20200201101548.GA19442@adacore.com> References: <20200107175458.GA31232@adacore.com> <20200109081731.42472-1-ldurfina@tachyum.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200109081731.42472-1-ldurfina@tachyum.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2020-02/txt/msg00010.txt.bz2 Hello, I had assumed you pushed the patch, but in double-checking, it does not seem that way. Apologies for the confusion. The patch is OK to wait, but can you include the ChangeLog entry in the revision log? It's been pretty traditional in the GDB project to have the revision log of the commit be the same as what's sent by email. I'll take this opportunity to make some suggestions on how to make the revision log a little more useful to those who use "git log" (I do it a lot myself). Typically, it looks like this: | Fix compilation error with musl in gdb/testsuite/gdb.base/fileio.c | | | | gdb/ChangeLog: | | * gdb.base/fileio.c: Remove #include of . | Replace #include of by . Thank you! On Thu, Jan 09, 2020 at 09:17:31AM +0100, Lukas Durfina wrote: > Fixed compilation with musl. > --- > gdb/testsuite/ChangeLog | 5 +++++ > gdb/testsuite/gdb.base/fileio.c | 3 +-- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog > index 3f243641b8..243721f6cb 100644 > --- a/gdb/testsuite/ChangeLog > +++ b/gdb/testsuite/ChangeLog > @@ -1,3 +1,8 @@ > +2020-01-09 Lukas Durfina > + > + * gdb.base/fileio.c: Remove #include of . > + Replace #include of by . > + > 2020-01-06 Andrew Burgess > > * gdb.base/backtrace.c: New file. > diff --git a/gdb/testsuite/gdb.base/fileio.c b/gdb/testsuite/gdb.base/fileio.c > index 7f482a34d3..0f201518b7 100644 > --- a/gdb/testsuite/gdb.base/fileio.c > +++ b/gdb/testsuite/gdb.base/fileio.c > @@ -1,13 +1,12 @@ > #include > #include > #include > -#include > #include > -#include > #include > #include > #include > #include > +#include > #include > #include > /* TESTS : > -- > 2.17.1 -- Joel