From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8483 invoked by alias); 7 Jan 2020 13:48:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8472 invoked by uid 89); 7 Jan 2020 13:47:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=H*r:0800 X-HELO: mail.tachyum.com Received: from mail.tachyum.com (HELO mail.tachyum.com) (66.160.133.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 07 Jan 2020 13:47:58 +0000 Received: from THQ-IP-EX1.tachyum.com (relayhost.tachyum.com [10.7.1.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.tachyum.com (Postfix) with ESMTPS id E7AFC62E; Tue, 7 Jan 2020 05:47:59 -0800 (PST) Received: from THQ-IP-EX1.tachyum.com (10.7.1.6) by THQ-IP-EX1.tachyum.com (10.7.1.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1779.2; Tue, 7 Jan 2020 05:47:44 -0800 Received: from THQ-IP-EX1.tachyum.com ([10.7.1.6]) by THQ-IP-EX1.tachyum.com ([10.7.1.6]) with mapi id 15.01.1779.007; Tue, 7 Jan 2020 05:47:38 -0800 From: Lukas Durfina To: Joel Brobecker CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH] gdb/testsuite: Updated includes Date: Tue, 07 Jan 2020 13:48:00 -0000 Message-ID: References: <20200102144714.93956-1-ldurfina@tachyum.com> <20200105062542.GB12588@adacore.com> In-Reply-To: <20200105062542.GB12588@adacore.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2020-01/txt/msg00146.txt.bz2 Hi Joel, Thanks for review. > -----Original Message----- > From: Joel Brobecker > Sent: Sunday, January 5, 2020 7:26 AM > To: Lukas Durfina > Cc: gdb-patches@sourceware.org > Subject: Re: [PATCH] gdb/testsuite: Updated includes >=20 > Hi Lukas, >=20 > > Fixed compilation error with musl. >=20 > Thanks for the patch! >=20 > > --- > > gdb/testsuite/ChangeLog | 4 ++++ > > gdb/testsuite/gdb.base/fileio.c | 3 +-- > > 2 files changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index > > f7835f35f7..89d403897c 100644 > > --- a/gdb/testsuite/ChangeLog > > +++ b/gdb/testsuite/ChangeLog > > @@ -1,3 +1,7 @@ > > +2020-01-02 Lukas Durfina > > + > > + * gdb.base/fileio.c: Updated includes to be more generic. >=20 > For the revision log, I think it's import to be a bit more specific when > explaining what changes you made and why. >=20 > I see you removed the #include without replacing it by a > #include of . However, this file does make references to errno, = so I > think there is an oversight there. There is already #include a few lines below, so I skipped it. >=20 > Also, I see you not only replace by , but you also= move > its include further down. Any reason for that. > Was it to move that include outside of the range of #include-s that inclu= de > files in "sys"? Exactly. My intention was to move it out of includes. No other re= ason. >=20 > For the ChangeLog, I think it is worth being a little more specific. > For instance, I would have written the ChangeLog as follow: >=20 > * gdb.base/fileio.c: Remove #include of . > Replace #include of by . >=20 > I'm usually the first in line to take shortcuts with ChangeLog files, but= I try to > be more informative when the cost of being so is so small... I see your point. Is it fine to send the patch with updated Changelog? Lukas >=20 > > + > > 2019-12-29 Bernd Edlinger > > > > * gdb.base/line65535.exp: New file. > > diff --git a/gdb/testsuite/gdb.base/fileio.c > > b/gdb/testsuite/gdb.base/fileio.c index 7f482a34d3..0f201518b7 100644 > > --- a/gdb/testsuite/gdb.base/fileio.c > > +++ b/gdb/testsuite/gdb.base/fileio.c > > @@ -1,13 +1,12 @@ > > #include > > #include > > #include > > -#include > > #include > > -#include > > #include > > #include > > #include > > #include > > +#include > > #include > > #include > > /* TESTS : > > -- > > 2.17.1 >=20 > -- > Joel