From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50806 invoked by alias); 3 Feb 2020 10:00:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45859 invoked by uid 89); 3 Feb 2020 10:00:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=H*r:0800, double-checking, doublechecking, opportunity X-HELO: mail.tachyum.com Received: from mail.tachyum.com (HELO mail.tachyum.com) (66.160.133.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Feb 2020 10:00:45 +0000 Received: by mail.tachyum.com (Postfix, from userid 1001) id 75D7C246; Mon, 3 Feb 2020 02:00:41 -0800 (PST) Received: from THQ-IP-EX1.tachyum.com (relayhost.tachyum.com [10.7.1.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.tachyum.com (Postfix) with ESMTPS id D0A1B246; Mon, 3 Feb 2020 02:00:40 -0800 (PST) Received: from THQ-IP-EX1.tachyum.com (10.7.1.6) by THQ-IP-EX1.tachyum.com (10.7.1.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1779.2; Mon, 3 Feb 2020 02:00:30 -0800 Received: from THQ-IP-EX1.tachyum.com ([10.7.1.6]) by THQ-IP-EX1.tachyum.com ([10.7.1.6]) with mapi id 15.01.1779.007; Mon, 3 Feb 2020 02:00:30 -0800 From: Lukas Durfina To: Joel Brobecker CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH] gdb/testsuite: Updated includes Date: Mon, 03 Feb 2020 10:00:00 -0000 Message-ID: <9ab5f3e7bd01457b87e887565b67cd8c@tachyum.com> References: <20200107175458.GA31232@adacore.com> <20200109081731.42472-1-ldurfina@tachyum.com> <20200201101548.GA19442@adacore.com> In-Reply-To: <20200201101548.GA19442@adacore.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2020-02/txt/msg00036.txt.bz2 >=20 > Hello, >=20 > I had assumed you pushed the patch, but in double-checking, it does not > seem that way. Apologies for the confusion. Hi Joel, Sorry, I was not sure what you mean by pushing.=20 I assume I cannot push directly to repo, so I sent a patch. Thanks for a hint. I am going to send an updated patch in the following ema= il. Best regards, Lukas >=20 > The patch is OK to wait, but can you include the ChangeLog entry in the > revision log? It's been pretty traditional in the GDB project to have the > revision log of the commit be the same as what's sent by email. I'll take= this > opportunity to make some suggestions on how to make the revision log a > little more useful to those who use "git log" (I do it a lot myself). Ty= pically, it > looks like this: >=20 > | Fix compilation error with musl in gdb/testsuite/gdb.base/fileio.c > | > | | understand the circumstances of the change should be provided here> > | > | gdb/ChangeLog: > | > | * gdb.base/fileio.c: Remove #include of . > | Replace #include of by . >=20 > Thank you! >=20 > On Thu, Jan 09, 2020 at 09:17:31AM +0100, Lukas Durfina wrote: > > Fixed compilation with musl. > > --- > > gdb/testsuite/ChangeLog | 5 +++++ > > gdb/testsuite/gdb.base/fileio.c | 3 +-- > > 2 files changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index > > 3f243641b8..243721f6cb 100644 > > --- a/gdb/testsuite/ChangeLog > > +++ b/gdb/testsuite/ChangeLog > > @@ -1,3 +1,8 @@ > > +2020-01-09 Lukas Durfina > > + > > + * gdb.base/fileio.c: Remove #include of . > > + Replace #include of by . > > + > > 2020-01-06 Andrew Burgess > > > > * gdb.base/backtrace.c: New file. > > diff --git a/gdb/testsuite/gdb.base/fileio.c > > b/gdb/testsuite/gdb.base/fileio.c index 7f482a34d3..0f201518b7 100644 > > --- a/gdb/testsuite/gdb.base/fileio.c > > +++ b/gdb/testsuite/gdb.base/fileio.c > > @@ -1,13 +1,12 @@ > > #include > > #include > > #include > > -#include > > #include > > -#include > > #include > > #include > > #include > > #include > > +#include > > #include > > #include > > /* TESTS : > > -- > > 2.17.1 >=20 > -- > Joel