Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [review] Add a dependency on import/Makefile and config.h
@ 2019-11-13  2:34 Christian Biesinger (Code Review)
  2019-11-13 16:15 ` Simon Marchi (Code Review)
                   ` (17 more replies)
  0 siblings, 18 replies; 19+ messages in thread
From: Christian Biesinger (Code Review) @ 2019-11-13  2:34 UTC (permalink / raw)
  To: gdb-patches; +Cc: Christian Biesinger

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/622
......................................................................

Add a dependency on import/Makefile and config.h

Otherwise, since nothing else depends on that, the Makefile won't be
regenerated when necessary, which is problematic when importing new
gnulib modules.

gnulib/ChangeLog:

2019-11-12  Christian Biesinger  <cbiesinger@google.com>

	* Makefile.in: Depend on import/Makefile and config.h.

Change-Id: I6a2c4d41cf4f0e21d5c813197bad63ed5c08e408
---
M gnulib/Makefile.in
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/gnulib/Makefile.in b/gnulib/Makefile.in
index a9879ed..2a00020 100644
--- a/gnulib/Makefile.in
+++ b/gnulib/Makefile.in
@@ -112,7 +112,7 @@
 	"RUNTEST=$(RUNTEST)" \
 	"RUNTESTFLAGS=$(RUNTESTFLAGS)"
 
-all installcheck check info install-info clean-info dvi pdf install-pdf html install-html: force
+all installcheck check info install-info clean-info dvi pdf install-pdf html install-html: force import/Makefile config.h
 	@$(MAKE) $(FLAGS_TO_PASS) DO=$@ "DODIRS=$(SUBDIRS)" subdir_do
 
 # Traditionally "install" depends on "all".  But it may be useful
@@ -131,7 +131,7 @@
 
 # Convenience rule to handle recursion.
 $(LIBGNU) $(GNULIB_H): all-lib
-all-lib: import/Makefile
+all-lib: import/Makefile config.h
 	@$(MAKE) $(FLAGS_TO_PASS) DO=all DODIRS=import subdir_do
 .PHONY: all-lib
 

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I6a2c4d41cf4f0e21d5c813197bad63ed5c08e408
Gerrit-Change-Number: 622
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-MessageType: newchange


^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2019-11-15 19:03 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-13  2:34 [review] Add a dependency on import/Makefile and config.h Christian Biesinger (Code Review)
2019-11-13 16:15 ` Simon Marchi (Code Review)
2019-11-13 16:31 ` Christian Biesinger (Code Review)
2019-11-13 16:32 ` Christian Biesinger (Code Review)
2019-11-14  5:36 ` Simon Marchi (Code Review)
2019-11-15  0:28 ` Christian Biesinger (Code Review)
2019-11-15  0:31 ` [review v2] Generate gnulib's toplevel Makefile.in using automake Christian Biesinger (Code Review)
2019-11-15  1:06 ` Simon Marchi (Code Review)
2019-11-15  1:12 ` [review v3] " Christian Biesinger (Code Review)
2019-11-15  1:13 ` Christian Biesinger (Code Review)
2019-11-15  1:16 ` Simon Marchi (Code Review)
2019-11-15  1:24 ` [review v4] " Christian Biesinger (Code Review)
2019-11-15  3:08 ` Simon Marchi (Code Review)
2019-11-15 13:20 ` Tom Tromey (Code Review)
2019-11-15 18:23 ` [review v5] " Christian Biesinger (Code Review)
2019-11-15 18:26 ` Christian Biesinger (Code Review)
2019-11-15 18:31 ` Tom Tromey (Code Review)
2019-11-15 19:03 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-15 19:03 ` Sourceware to Gerrit sync (Code Review)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox