[review v5] Generate gnulib's toplevel Makefile.in using automake

["Christian Biesinger (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Christian Biesinger has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/622
......................................................................


Patch Set 5:

(2 comments)

| --- gnulib/update-gnulib.sh
| +++ gnulib/update-gnulib.sh
| @@ -168,22 +168,17 @@ apply_patches ()
|          exit 1
|      fi
|  }
|  
|  apply_patches "patches/0001-Fix-PR-gdb-23558-Use-system-s-getcwd-when-cross-comp.patch"
|  apply_patches "patches/0002-mkostemp-mkostemps-Fix-compilation-error-in-C-mode-o.patch"
|  apply_patches "patches/0003-Fix-glob-c-Coverity-issues.patch"
|  
|  # Regenerate all necessary files...
|  aclocal -Iimport/m4 -I../config &&

PS4, Line 177:

Thanks, done.

|  autoconf &&
|  autoheader &&
| -automake
| +automake --foreign

PS4, Line 180:

Ah, thanks, done.

|  if [ $? -ne 0 ]; then
|     echo "Error: Failed to regenerate Makefiles and configure scripts."
|     exit 1
|  fi
| -
| -# Update aclocal-m4-deps.mk
| -ACLOCAL_M4_DEPS_FILE=aclocal-m4-deps.mk
| -cat > ${ACLOCAL_M4_DEPS_FILE}.tmp <<EOF
| -# THIS FILE IS GENERATED.  -*- buffer-read-only: t -*- vi :set ro:

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I6a2c4d41cf4f0e21d5c813197bad63ed5c08e408
Gerrit-Change-Number: 622
Gerrit-PatchSet: 5
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Fri, 15 Nov 2019 18:26:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: comment