From: "Christian Biesinger (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
Tom Tromey <tromey@sourceware.org>
Subject: [review v3] Generate gnulib's toplevel Makefile.in using automake
Date: Fri, 15 Nov 2019 01:13:00 -0000 [thread overview]
Message-ID: <20191115011333.58DAD20AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1573612444000.I6a2c4d41cf4f0e21d5c813197bad63ed5c08e408@gnutoolchain-gerrit.osci.io>
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/622
......................................................................
Patch Set 3:
> Patch Set 2:
>
> The file gnulib/aclocal-m4-deps.mk is not used anymore. I believe that the automake-generated Makefile.in offers the feature that we did by hand using that file, so I think it's fine to just get rid of it.
Thanks, I was wondering about that. Now deleted.
> I'm adding Tom as a reviewer, as he has some experience with Automake, I believe, so he might be able to spot some problems that I did not.
I did notice his name in "man automake" :)
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I6a2c4d41cf4f0e21d5c813197bad63ed5c08e408
Gerrit-Change-Number: 622
Gerrit-PatchSet: 3
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Fri, 15 Nov 2019 01:13:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-15 1:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 2:34 [review] Add a dependency on import/Makefile and config.h Christian Biesinger (Code Review)
2019-11-13 16:15 ` Simon Marchi (Code Review)
2019-11-13 16:31 ` Christian Biesinger (Code Review)
2019-11-13 16:32 ` Christian Biesinger (Code Review)
2019-11-14 5:36 ` Simon Marchi (Code Review)
2019-11-15 0:28 ` Christian Biesinger (Code Review)
2019-11-15 0:31 ` [review v2] Generate gnulib's toplevel Makefile.in using automake Christian Biesinger (Code Review)
2019-11-15 1:06 ` Simon Marchi (Code Review)
2019-11-15 1:12 ` [review v3] " Christian Biesinger (Code Review)
2019-11-15 1:13 ` Christian Biesinger (Code Review) [this message]
2019-11-15 1:16 ` Simon Marchi (Code Review)
2019-11-15 1:24 ` [review v4] " Christian Biesinger (Code Review)
2019-11-15 3:08 ` Simon Marchi (Code Review)
2019-11-15 13:20 ` Tom Tromey (Code Review)
2019-11-15 18:23 ` [review v5] " Christian Biesinger (Code Review)
2019-11-15 18:26 ` Christian Biesinger (Code Review)
2019-11-15 18:31 ` Tom Tromey (Code Review)
2019-11-15 19:03 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-15 19:03 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115011333.58DAD20AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=simon.marchi@polymtl.ca \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox