Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Christian Biesinger (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: [review] Add a dependency on import/Makefile and config.h
Date: Wed, 13 Nov 2019 02:34:00 -0000	[thread overview]
Message-ID: <gerrit.1573612444000.I6a2c4d41cf4f0e21d5c813197bad63ed5c08e408@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1573612444000.I6a2c4d41cf4f0e21d5c813197bad63ed5c08e408@gnutoolchain-gerrit.osci.io>

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/622
......................................................................

Add a dependency on import/Makefile and config.h

Otherwise, since nothing else depends on that, the Makefile won't be
regenerated when necessary, which is problematic when importing new
gnulib modules.

gnulib/ChangeLog:

2019-11-12  Christian Biesinger  <cbiesinger@google.com>

	* Makefile.in: Depend on import/Makefile and config.h.

Change-Id: I6a2c4d41cf4f0e21d5c813197bad63ed5c08e408
---
M gnulib/Makefile.in
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/gnulib/Makefile.in b/gnulib/Makefile.in
index a9879ed..2a00020 100644
--- a/gnulib/Makefile.in
+++ b/gnulib/Makefile.in
@@ -112,7 +112,7 @@
 	"RUNTEST=$(RUNTEST)" \
 	"RUNTESTFLAGS=$(RUNTESTFLAGS)"
 
-all installcheck check info install-info clean-info dvi pdf install-pdf html install-html: force
+all installcheck check info install-info clean-info dvi pdf install-pdf html install-html: force import/Makefile config.h
 	@$(MAKE) $(FLAGS_TO_PASS) DO=$@ "DODIRS=$(SUBDIRS)" subdir_do
 
 # Traditionally "install" depends on "all".  But it may be useful
@@ -131,7 +131,7 @@
 
 # Convenience rule to handle recursion.
 $(LIBGNU) $(GNULIB_H): all-lib
-all-lib: import/Makefile
+all-lib: import/Makefile config.h
 	@$(MAKE) $(FLAGS_TO_PASS) DO=all DODIRS=import subdir_do
 .PHONY: all-lib
 

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I6a2c4d41cf4f0e21d5c813197bad63ed5c08e408
Gerrit-Change-Number: 622
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-MessageType: newchange


       reply	other threads:[~2019-11-13  2:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13  2:34 Christian Biesinger (Code Review) [this message]
2019-11-13 16:15 ` Simon Marchi (Code Review)
2019-11-13 16:31 ` Christian Biesinger (Code Review)
2019-11-13 16:32 ` Christian Biesinger (Code Review)
2019-11-14  5:36 ` Simon Marchi (Code Review)
2019-11-15  0:28 ` Christian Biesinger (Code Review)
2019-11-15  0:31 ` [review v2] Generate gnulib's toplevel Makefile.in using automake Christian Biesinger (Code Review)
2019-11-15  1:06 ` Simon Marchi (Code Review)
2019-11-15  1:12 ` [review v3] " Christian Biesinger (Code Review)
2019-11-15  1:13 ` Christian Biesinger (Code Review)
2019-11-15  1:16 ` Simon Marchi (Code Review)
2019-11-15  1:24 ` [review v4] " Christian Biesinger (Code Review)
2019-11-15  3:08 ` Simon Marchi (Code Review)
2019-11-15 13:20 ` Tom Tromey (Code Review)
2019-11-15 18:23 ` [review v5] " Christian Biesinger (Code Review)
2019-11-15 18:26 ` Christian Biesinger (Code Review)
2019-11-15 18:31 ` Tom Tromey (Code Review)
2019-11-15 19:03 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-15 19:03 ` Sourceware to Gerrit sync (Code Review)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gerrit.1573612444000.I6a2c4d41cf4f0e21d5c813197bad63ed5c08e408@gnutoolchain-gerrit.osci.io \
    --to=gerrit@gnutoolchain-gerrit.osci.io \
    --cc=cbiesinger@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox