From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5455 invoked by alias); 15 Nov 2019 01:13:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5441 invoked by uid 89); 15 Nov 2019 01:13:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Nov 2019 01:13:39 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 4C0CF20339; Thu, 14 Nov 2019 20:13:38 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 7394C20339; Thu, 14 Nov 2019 20:13:33 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 58DAD20AF6; Thu, 14 Nov 2019 20:13:33 -0500 (EST) X-Gerrit-PatchSet: 3 Date: Fri, 15 Nov 2019 01:13:00 -0000 From: "Christian Biesinger (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Simon Marchi , Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] Generate gnulib's toplevel Makefile.in using automake X-Gerrit-Change-Id: I6a2c4d41cf4f0e21d5c813197bad63ed5c08e408 X-Gerrit-Change-Number: 622 X-Gerrit-ChangeURL: X-Gerrit-Commit: f6fbf72f0af74bc187eefb2c7165de3d5e70f899 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 14 Nov 2019 20:13:33 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191115011333.58DAD20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00451.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/622 ...................................................................... Patch Set 3: > Patch Set 2: > > The file gnulib/aclocal-m4-deps.mk is not used anymore. I believe that the automake-generated Makefile.in offers the feature that we did by hand using that file, so I think it's fine to just get rid of it. Thanks, I was wondering about that. Now deleted. > I'm adding Tom as a reviewer, as he has some experience with Automake, I believe, so he might be able to spot some problems that I did not. I did notice his name in "man automake" :) -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I6a2c4d41cf4f0e21d5c813197bad63ed5c08e408 Gerrit-Change-Number: 622 Gerrit-PatchSet: 3 Gerrit-Owner: Christian Biesinger Gerrit-Reviewer: Christian Biesinger Gerrit-Reviewer: Simon Marchi Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Fri, 15 Nov 2019 01:13:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment