From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8336 invoked by alias); 13 Nov 2019 16:32:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8327 invoked by uid 89); 13 Nov 2019 16:32:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Nov 2019 16:32:35 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 6A2E72046F; Wed, 13 Nov 2019 11:32:32 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 6234A201E8; Wed, 13 Nov 2019 11:32:31 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 425F820AF6; Wed, 13 Nov 2019 11:32:31 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Wed, 13 Nov 2019 16:32:00 -0000 From: "Christian Biesinger (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Add a dependency on import/Makefile and config.h X-Gerrit-Change-Id: I6a2c4d41cf4f0e21d5c813197bad63ed5c08e408 X-Gerrit-Change-Number: 622 X-Gerrit-ChangeURL: X-Gerrit-Commit: 591211cacdb5d3c5aa70380476b3a166296f6e64 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 13 Nov 2019 11:32:30 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191113163231.425F820AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00362.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/622 ...................................................................... Patch Set 1: > Patch Set 1: > > > Patch Set 1: > > > > Can you explain quickly the logic of this? I am not completely aware of what generates what in this system, so if you could explain at high level what happens between importing a new gnulib module, and the Makefile/config.h getting re-generated, it would help. > > Sure. So if a new module is imported, it will likely change what #defines get defined, which means config.h needs to be regenerated. Also, import/Makefile.in sets various variables similar to those defines such as REPLACE_STRERROR_R, and so it needs to be regenerated as well (those variables are used to generate headers like string.h) > > But nothing currently ensures that those two get regenerated. Hence these new dependencies. all-lib was already depending on import/Makefile, presumably for this purpose, but does not seem to be used. Sorry, to clarify, these are the steps that cause issues: - Have an existing GDB build <-- important - Run update-gnulib - Run make in your build directory <-- this is now using the old config.h and import/Makefile -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I6a2c4d41cf4f0e21d5c813197bad63ed5c08e408 Gerrit-Change-Number: 622 Gerrit-PatchSet: 1 Gerrit-Owner: Christian Biesinger Gerrit-Reviewer: Christian Biesinger Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Wed, 13 Nov 2019 16:32:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment