From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57949 invoked by alias); 15 Nov 2019 13:20:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57930 invoked by uid 89); 15 Nov 2019 13:20:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-13.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Nov 2019 13:20:54 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id BFB4020562; Fri, 15 Nov 2019 08:20:52 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 939032032F; Fri, 15 Nov 2019 08:20:46 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 6FD1C20AF6; Fri, 15 Nov 2019 08:20:46 -0500 (EST) X-Gerrit-PatchSet: 4 Date: Fri, 15 Nov 2019 13:20:00 -0000 From: "Tom Tromey (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v4] Generate gnulib's toplevel Makefile.in using automake X-Gerrit-Change-Id: I6a2c4d41cf4f0e21d5c813197bad63ed5c08e408 X-Gerrit-Change-Number: 622 X-Gerrit-ChangeURL: X-Gerrit-Commit: fe51f938bba1922723af160708fb69c72f3fff53 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 15 Nov 2019 08:20:46 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191115132046.6FD1C20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00462.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/622 ...................................................................... Patch Set 4: (2 comments) Thanks for doing this. It looks good to me. I think it needs a couple of minor tweaks. | --- gnulib/update-gnulib.sh | +++ gnulib/update-gnulib.sh | @@ -168,22 +168,17 @@ apply_patches () | exit 1 | fi | } | | apply_patches "patches/0001-Fix-PR-gdb-23558-Use-system-s-getcwd-when-cross-comp.patch" | apply_patches "patches/0002-mkostemp-mkostemps-Fix-compilation-error-in-C-mode-o.patch" | apply_patches "patches/0003-Fix-glob-c-Coverity-issues.patch" | | # Regenerate all necessary files... | aclocal -Iimport/m4 -I../config && PS4, Line 177: I think if you need -I options to aclocal, you should also invoke AC_CONFIG_MACRO_DIRS in configure.ac. See https://www.gnu.org/software/automake/manual/automake.html#Local- Macros | autoconf && | autoheader && | -automake | +automake --foreign PS4, Line 180: Rather than write --foreign here, add `foreign` to the call to `AM_INIT_AUTOMAKE` in `configure.ac`. | if [ $? -ne 0 ]; then | echo "Error: Failed to regenerate Makefiles and configure scripts." | exit 1 | fi | - | -# Update aclocal-m4-deps.mk | -ACLOCAL_M4_DEPS_FILE=aclocal-m4-deps.mk | -cat > ${ACLOCAL_M4_DEPS_FILE}.tmp < Gerrit-Reviewer: Christian Biesinger Gerrit-Reviewer: Simon Marchi Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Fri, 15 Nov 2019 13:20:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment