Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Matt Rice <ratmice@gmail.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Fiodar Stryzhniou <fedor_qd@mail.ru>,
	Andreas Schwab <schwab@linux-m68k.org>,
		Petr Ovtchenkov <ptr@void-ptr.info>,
	Binutils <binutils@sourceware.org>,
		Joel Brobecker <brobecker@adacore.com>,
	Matthias Klose <doko@ubuntu.com>, GDB <gdb@sourceware.org>
Subject: Re: meaning of "Automatic date update in version.in" commits
Date: Thu, 21 Sep 2017 17:31:00 -0000	[thread overview]
Message-ID: <CACTLOFp-6gOC8by8=qFuLOxy6G0zxCizFiRvJ-vXS_dtQKBKhQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1709211714120.32415@digraph.polyomino.org.uk>

On Thu, Sep 21, 2017 at 10:17 AM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Thu, 21 Sep 2017, Matt Rice wrote:
>
>> option A. seems to be using git smudge/filter to on checkout populate
>> the version.in using a smudge rule, and then filtering it out using a
>> filter,
>>               acting much like the RCS keywords...
>>   pros: no extra commit stuff at all
>>   cons: requires setting up git config stuff in the repository for
>> executing the smudge/filter rules on checkout
>>            this should likely be checked by the configure process e.g.
>> configure should produce an error telling the user to enable the
>> smudge/filter rules
>>           when the version is $Date$ rather an actual date...
>
> I don't think there should be anything that requires people to check out
> in a special way, or to configure their checkouts specially, rather than
> just using "git clone" and a subsequent build.  Generic tools such as
> build bots may have generic knowledge of how to check out and update git
> checkouts; they should not need binutils-specific extras to that
> knowledge.

Indeed i was looking at it the other way, in that build bots etc need
binutils-specific knowledge in order to ignore these commits
to avoid unnecessary work, but your point seems valid.


  reply	other threads:[~2017-09-21 17:31 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-21  5:03 Fiodar Stryzhniou via gdb
2017-09-21  8:42 ` Matt Rice
2017-09-21 10:58   ` Petr Ovtchenkov
2017-09-21 11:37     ` Pedro Alves
     [not found]       ` <20170921152240.16bb4cc0@void-ptr.info>
2017-09-21 12:39         ` Pedro Alves
2017-09-21 13:17           ` Petr Ovtchenkov
2017-09-21 13:34             ` Simon Marchi
2017-09-21 15:46               ` Petr Ovtchenkov
2017-09-21 16:01                 ` Simon Marchi
2017-09-21 16:03                 ` Matthias Klose
2017-09-21 16:26                   ` Petr Ovtchenkov
2017-09-21 16:34                     ` Joel Brobecker
2017-09-21 16:52                       ` Petr Ovtchenkov
2017-09-21 17:00                         ` Joel Brobecker
2017-09-21 17:39                           ` Petr Ovtchenkov
2017-09-21 23:59                             ` Alan Modra
2017-09-22  5:31                               ` Petr Ovtchenkov
2017-09-22  6:49                                 ` Andreas Schwab
2017-09-22  9:29                                   ` Petr Ovtchenkov
2017-09-22 22:26                                   ` H.J. Lu
2017-09-22 22:35                                   ` H.J. Lu
2017-09-22  9:49                               ` [PATCH] bfd/version.h: Add rationale for BFD_VERSION_DATE (Re: meaning of "Automatic date update in version.in" commits) Pedro Alves
2017-09-22 13:38                                 ` Alan Modra
2017-09-22 13:47                                   ` Joel Brobecker
2017-09-22 13:59                                     ` Pedro Alves
2017-09-21 17:17   ` meaning of "Automatic date update in version.in" commits Joseph Myers
2017-09-21 17:31     ` Matt Rice [this message]
     [not found] <20170920173622.28500ccf@void-ptr.info>
2017-09-20 15:05 ` Joel Brobecker
2017-09-20 15:33   ` Petr Ovtchenkov
2017-09-21 17:07     ` Ian Lance Taylor via gdb
2017-09-20 15:40   ` Matthias Klose
2017-09-20 15:48     ` Dmitry Samersoff
     [not found] ` <87zi9p2vma.fsf@linux-m68k.org>
2017-09-20 17:24   ` Petr Ovtchenkov
     [not found]     ` <7217d33d-61eb-732e-dfd6-80ef4908743e@ubuntu.com>
2017-09-20 19:21       ` Petr Ovtchenkov
2017-09-20 19:27       ` Mikhail Terekhov
2017-09-20 19:56         ` Philippe Waroquiers
2017-09-20 19:57         ` Matthias Klose
2017-09-20 20:07           ` Philippe Waroquiers
2017-09-20 20:21             ` Matthias Klose
2017-09-20 20:26               ` Philippe Waroquiers
2017-09-20 20:31                 ` Petr Ovtchenkov
2017-09-20 20:39                   ` Philippe Waroquiers
2017-09-20 20:34           ` Mikhail Terekhov
2017-09-20 21:34     ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACTLOFp-6gOC8by8=qFuLOxy6G0zxCizFiRvJ-vXS_dtQKBKhQ@mail.gmail.com' \
    --to=ratmice@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=brobecker@adacore.com \
    --cc=doko@ubuntu.com \
    --cc=fedor_qd@mail.ru \
    --cc=gdb@sourceware.org \
    --cc=joseph@codesourcery.com \
    --cc=ptr@void-ptr.info \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox