From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21729 invoked by alias); 21 Sep 2017 17:31:50 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 20767 invoked by uid 89); 21 Sep 2017 17:31:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS,URIBL_RED autolearn=no version=3.3.2 spammy=Hx-languages-length:1310, telling X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-lf0-f45.google.com Received: from mail-lf0-f45.google.com (HELO mail-lf0-f45.google.com) (209.85.215.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Sep 2017 17:31:47 +0000 Received: by mail-lf0-f45.google.com with SMTP id k9so6429579lfe.10; Thu, 21 Sep 2017 10:31:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=FbJub7UGL8cOWwT4mfniA7qjHaSsj5Qw+fnyjiZHI7E=; b=QvDDwVs2WBGuHTHXJsGE07v6WwwCboyZwOlUIi0taiHhd9pWovPddY3TYsIu6rw82L IVJaXMFCyFHecZTZnk1cruTQ8/591cP4oJRvc6SK+amklnvme3RmU0dG7lsiLTk8UwnD ldXhw6ksKT/R/VjwlYYEO5lucA9W74OSTArLMb1fKA8zvjXy46fm3IUyB38ERFxh9PY0 ld/Cb2pH+X2E7gAQ5tyclORpCld1qSNcJDIklwHPQ20UdeyLo4GQJtzeaN1S6mgu5U/w p9AeS+LJO6RrHMYN0lN+RdDygDGCAPWt34WxJ4g8pvNWWl+Y1pCvfzKdZhB7GbbFcYpI R+og== X-Gm-Message-State: AHPjjUid3oYjjIE9/Wp7nSgRjd78grh561luSYiVEZnm1tu3GPuDApaF +FB0SWdSYuFafle0utCPRMbFk9c5A6ytTn9WzjY= X-Google-Smtp-Source: AOwi7QA5oMaqoJotJQEpL03VwW+TRbIi0Yfgn3PYyyiET7ZOVULWGCQucoUIJwJVarbJFJ4266UJ7ah7PQLbj5g9vEc= X-Received: by 10.46.82.20 with SMTP id g20mr1288194ljb.150.1506015105476; Thu, 21 Sep 2017 10:31:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.235.197 with HTTP; Thu, 21 Sep 2017 10:31:44 -0700 (PDT) In-Reply-To: References: From: Matt Rice Date: Thu, 21 Sep 2017 17:31:00 -0000 Message-ID: Subject: Re: meaning of "Automatic date update in version.in" commits To: Joseph Myers Cc: Fiodar Stryzhniou , Andreas Schwab , Petr Ovtchenkov , Binutils , Joel Brobecker , Matthias Klose , GDB Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00090.txt.bz2 On Thu, Sep 21, 2017 at 10:17 AM, Joseph Myers wrote: > On Thu, 21 Sep 2017, Matt Rice wrote: > >> option A. seems to be using git smudge/filter to on checkout populate >> the version.in using a smudge rule, and then filtering it out using a >> filter, >> acting much like the RCS keywords... >> pros: no extra commit stuff at all >> cons: requires setting up git config stuff in the repository for >> executing the smudge/filter rules on checkout >> this should likely be checked by the configure process e.g. >> configure should produce an error telling the user to enable the >> smudge/filter rules >> when the version is $Date$ rather an actual date... > > I don't think there should be anything that requires people to check out > in a special way, or to configure their checkouts specially, rather than > just using "git clone" and a subsequent build. Generic tools such as > build bots may have generic knowledge of how to check out and update git > checkouts; they should not need binutils-specific extras to that > knowledge. Indeed i was looking at it the other way, in that build bots etc need binutils-specific knowledge in order to ignore these commits to avoid unnecessary work, but your point seems valid.