* RFA: Don't use -Wuninitialized if CFLAGS omits -O [not found] <vt2is4c77ng.fsf@zenia.home> @ 2005-03-11 21:02 ` Jim Blandy 2005-03-12 9:05 ` Joel Brobecker 1 sibling, 0 replies; 6+ messages in thread From: Jim Blandy @ 2005-03-11 21:02 UTC (permalink / raw) To: gdb-patches I've committed this. > This allows gdb_mbuild.sh to work with CFLAGS=-g, which improves > compilation speed and helps with debugging. > > 2005-02-28 Jim Blandy <jimb@redhat.com> > > Avoid warnings due to the use of -Wuninitialized without -O. > * configure.ac (build_warnings): Include -Wuninitialized only if > CFLAGS is unset at configure time, or CFLAGS is set and includes > some -O option other than -O0. > * configure: Regenerated. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RFA: Don't use -Wuninitialized if CFLAGS omits -O [not found] <vt2is4c77ng.fsf@zenia.home> 2005-03-11 21:02 ` RFA: Don't use -Wuninitialized if CFLAGS omits -O Jim Blandy @ 2005-03-12 9:05 ` Joel Brobecker 2005-03-12 15:06 ` Andreas Schwab 2005-03-12 15:32 ` Daniel Jacobowitz 1 sibling, 2 replies; 6+ messages in thread From: Joel Brobecker @ 2005-03-12 9:05 UTC (permalink / raw) To: Jim Blandy; +Cc: gdb-patches Jim, > 2005-02-28 Jim Blandy <jimb@redhat.com> > > Avoid warnings due to the use of -Wuninitialized without -O. > * configure.ac (build_warnings): Include -Wuninitialized only if > CFLAGS is unset at configure time, or CFLAGS is set and includes > some -O option other than -O0. > * configure: Regenerated. I think there is a slight problem that broke the build with non-GNU bourne shells. We have a build failure on our solaris 2.8 machine, for instance. Here is what I think the problem is: > + # GCC supports -Wuninitialized only with -O or -On, n != 0. > + if test x${CFLAGS+set} == xset; then ^^ I think the "==" should be "=", no? That's what "man test" documents. But I've never been a shell guru... -- Joel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RFA: Don't use -Wuninitialized if CFLAGS omits -O 2005-03-12 9:05 ` Joel Brobecker @ 2005-03-12 15:06 ` Andreas Schwab 2005-03-12 15:32 ` Daniel Jacobowitz 1 sibling, 0 replies; 6+ messages in thread From: Andreas Schwab @ 2005-03-12 15:06 UTC (permalink / raw) To: Joel Brobecker; +Cc: Jim Blandy, gdb-patches Joel Brobecker <brobecker@adacore.com> writes: >> + # GCC supports -Wuninitialized only with -O or -On, n != 0. >> + if test x${CFLAGS+set} == xset; then > ^^ > I think the "==" should be "=", no? That's what "man test" documents. Yes, "=" is correct, "==" is implemented in some shells (like bash and ksh) as extension. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RFA: Don't use -Wuninitialized if CFLAGS omits -O 2005-03-12 9:05 ` Joel Brobecker 2005-03-12 15:06 ` Andreas Schwab @ 2005-03-12 15:32 ` Daniel Jacobowitz 2005-03-12 20:15 ` Joel Brobecker 1 sibling, 1 reply; 6+ messages in thread From: Daniel Jacobowitz @ 2005-03-12 15:32 UTC (permalink / raw) To: Joel Brobecker; +Cc: Jim Blandy, gdb-patches On Sat, Mar 12, 2005 at 01:05:06AM -0800, Joel Brobecker wrote: > Jim, > > > 2005-02-28 Jim Blandy <jimb@redhat.com> > > > > Avoid warnings due to the use of -Wuninitialized without -O. > > * configure.ac (build_warnings): Include -Wuninitialized only if > > CFLAGS is unset at configure time, or CFLAGS is set and includes > > some -O option other than -O0. > > * configure: Regenerated. > > I think there is a slight problem that broke the build with non-GNU > bourne shells. We have a build failure on our solaris 2.8 machine, > for instance. Here is what I think the problem is: > > > + # GCC supports -Wuninitialized only with -O or -On, n != 0. > > + if test x${CFLAGS+set} == xset; then > ^^ > I think the "==" should be "=", no? That's what "man test" documents. > But I've never been a shell guru... Yes, that's right. Would you mind fixing this? -- Daniel Jacobowitz CodeSourcery, LLC ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RFA: Don't use -Wuninitialized if CFLAGS omits -O 2005-03-12 15:32 ` Daniel Jacobowitz @ 2005-03-12 20:15 ` Joel Brobecker 2005-03-13 5:38 ` Jim Blandy 0 siblings, 1 reply; 6+ messages in thread From: Joel Brobecker @ 2005-03-12 20:15 UTC (permalink / raw) To: Jim Blandy, gdb-patches > > I think there is a slight problem that broke the build with non-GNU > > bourne shells. We have a build failure on our solaris 2.8 machine, > > for instance. Here is what I think the problem is: > > > > > + # GCC supports -Wuninitialized only with -O or -On, n != 0. > > > + if test x${CFLAGS+set} == xset; then > > ^^ > > I think the "==" should be "=", no? That's what "man test" documents. > > But I've never been a shell guru... > > Yes, that's right. Would you mind fixing this? Sure, wildo later today. -- Joel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: RFA: Don't use -Wuninitialized if CFLAGS omits -O 2005-03-12 20:15 ` Joel Brobecker @ 2005-03-13 5:38 ` Jim Blandy 0 siblings, 0 replies; 6+ messages in thread From: Jim Blandy @ 2005-03-13 5:38 UTC (permalink / raw) To: Joel Brobecker; +Cc: gdb-patches Joel Brobecker <brobecker@adacore.com> writes: > > > I think there is a slight problem that broke the build with non-GNU > > > bourne shells. We have a build failure on our solaris 2.8 machine, > > > for instance. Here is what I think the problem is: > > > > > > > + # GCC supports -Wuninitialized only with -O or -On, n != 0. > > > > + if test x${CFLAGS+set} == xset; then > > > ^^ > > > I think the "==" should be "=", no? That's what "man test" documents. > > > But I've never been a shell guru... > > > > Yes, that's right. Would you mind fixing this? > > Sure, wildo later today. Beat you to it. Sorry about that. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-03-13 5:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <vt2is4c77ng.fsf@zenia.home>
2005-03-11 21:02 ` RFA: Don't use -Wuninitialized if CFLAGS omits -O Jim Blandy
2005-03-12 9:05 ` Joel Brobecker
2005-03-12 15:06 ` Andreas Schwab
2005-03-12 15:32 ` Daniel Jacobowitz
2005-03-12 20:15 ` Joel Brobecker
2005-03-13 5:38 ` Jim Blandy
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox