From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22323 invoked by alias); 13 Mar 2005 05:38:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22001 invoked from network); 13 Mar 2005 05:37:58 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 13 Mar 2005 05:37:58 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j2D5bwJE028432 for ; Sun, 13 Mar 2005 00:37:58 -0500 Received: from zenia.home.redhat.com (sebastian-int.corp.redhat.com [172.16.52.221]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j2D5bvY10114; Sun, 13 Mar 2005 00:37:57 -0500 To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: Don't use -Wuninitialized if CFLAGS omits -O References: <20050312090506.GU1156@adacore.com> <20050312153235.GA11899@nevyn.them.org> <20050312201528.GV1156@adacore.com> From: Jim Blandy Date: Sun, 13 Mar 2005 05:38:00 -0000 In-Reply-To: <20050312201528.GV1156@adacore.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2005-03/txt/msg00192.txt.bz2 Joel Brobecker writes: > > > I think there is a slight problem that broke the build with non-GNU > > > bourne shells. We have a build failure on our solaris 2.8 machine, > > > for instance. Here is what I think the problem is: > > > > > > > + # GCC supports -Wuninitialized only with -O or -On, n != 0. > > > > + if test x${CFLAGS+set} == xset; then > > > ^^ > > > I think the "==" should be "=", no? That's what "man test" documents. > > > But I've never been a shell guru... > > > > Yes, that's right. Would you mind fixing this? > > Sure, wildo later today. Beat you to it. Sorry about that.