Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Jim Blandy <jimb@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: RFA: Don't use -Wuninitialized if CFLAGS omits -O
Date: Sat, 12 Mar 2005 15:06:00 -0000	[thread overview]
Message-ID: <jefyz0rjjm.fsf@sykes.suse.de> (raw)
In-Reply-To: <20050312090506.GU1156@adacore.com> (Joel Brobecker's message of "Sat, 12 Mar 2005 01:05:06 -0800")

Joel Brobecker <brobecker@adacore.com> writes:

>> + # GCC supports -Wuninitialized only with -O or -On, n != 0.
>> + if test x${CFLAGS+set} == xset; then
>                            ^^
> I think the "==" should be "=", no? That's what "man test" documents.

Yes, "=" is correct, "==" is implemented in some shells (like bash and
ksh) as extension.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


  reply	other threads:[~2005-03-12 15:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <vt2is4c77ng.fsf@zenia.home>
2005-03-11 21:02 ` Jim Blandy
2005-03-12  9:05 ` Joel Brobecker
2005-03-12 15:06   ` Andreas Schwab [this message]
2005-03-12 15:32   ` Daniel Jacobowitz
2005-03-12 20:15     ` Joel Brobecker
2005-03-13  5:38       ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jefyz0rjjm.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox