From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Jim Blandy <jimb@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: RFA: Don't use -Wuninitialized if CFLAGS omits -O
Date: Sat, 12 Mar 2005 15:32:00 -0000 [thread overview]
Message-ID: <20050312153235.GA11899@nevyn.them.org> (raw)
In-Reply-To: <20050312090506.GU1156@adacore.com>
On Sat, Mar 12, 2005 at 01:05:06AM -0800, Joel Brobecker wrote:
> Jim,
>
> > 2005-02-28 Jim Blandy <jimb@redhat.com>
> >
> > Avoid warnings due to the use of -Wuninitialized without -O.
> > * configure.ac (build_warnings): Include -Wuninitialized only if
> > CFLAGS is unset at configure time, or CFLAGS is set and includes
> > some -O option other than -O0.
> > * configure: Regenerated.
>
> I think there is a slight problem that broke the build with non-GNU
> bourne shells. We have a build failure on our solaris 2.8 machine,
> for instance. Here is what I think the problem is:
>
> > + # GCC supports -Wuninitialized only with -O or -On, n != 0.
> > + if test x${CFLAGS+set} == xset; then
> ^^
> I think the "==" should be "=", no? That's what "man test" documents.
> But I've never been a shell guru...
Yes, that's right. Would you mind fixing this?
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-03-12 15:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <vt2is4c77ng.fsf@zenia.home>
2005-03-11 21:02 ` Jim Blandy
2005-03-12 9:05 ` Joel Brobecker
2005-03-12 15:06 ` Andreas Schwab
2005-03-12 15:32 ` Daniel Jacobowitz [this message]
2005-03-12 20:15 ` Joel Brobecker
2005-03-13 5:38 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050312153235.GA11899@nevyn.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox