From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1425 invoked by alias); 12 Mar 2005 15:32:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1348 invoked from network); 12 Mar 2005 15:32:52 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 12 Mar 2005 15:32:52 -0000 Received: from drow by nevyn.them.org with local (Exim 4.44 #1 (Debian)) id 1DA8bT-00036V-NA; Sat, 12 Mar 2005 10:32:35 -0500 Date: Sat, 12 Mar 2005 15:32:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: Jim Blandy , gdb-patches@sources.redhat.com Subject: Re: RFA: Don't use -Wuninitialized if CFLAGS omits -O Message-ID: <20050312153235.GA11899@nevyn.them.org> Mail-Followup-To: Joel Brobecker , Jim Blandy , gdb-patches@sources.redhat.com References: <20050312090506.GU1156@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050312090506.GU1156@adacore.com> User-Agent: Mutt/1.5.6+20040907i X-SW-Source: 2005-03/txt/msg00189.txt.bz2 On Sat, Mar 12, 2005 at 01:05:06AM -0800, Joel Brobecker wrote: > Jim, > > > 2005-02-28 Jim Blandy > > > > Avoid warnings due to the use of -Wuninitialized without -O. > > * configure.ac (build_warnings): Include -Wuninitialized only if > > CFLAGS is unset at configure time, or CFLAGS is set and includes > > some -O option other than -O0. > > * configure: Regenerated. > > I think there is a slight problem that broke the build with non-GNU > bourne shells. We have a build failure on our solaris 2.8 machine, > for instance. Here is what I think the problem is: > > > + # GCC supports -Wuninitialized only with -O or -On, n != 0. > > + if test x${CFLAGS+set} == xset; then > ^^ > I think the "==" should be "=", no? That's what "man test" documents. > But I've never been a shell guru... Yes, that's right. Would you mind fixing this? -- Daniel Jacobowitz CodeSourcery, LLC