From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4627 invoked by alias); 12 Mar 2005 15:06:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4570 invoked from network); 12 Mar 2005 15:05:58 -0000 Received: from unknown (HELO Cantor.suse.de) (195.135.220.2) by sourceware.org with SMTP; 12 Mar 2005 15:05:58 -0000 Received: from hermes.suse.de (hermes-ext.suse.de [195.135.221.8]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by Cantor.suse.de (Postfix) with ESMTP id 5690F15B5F8D; Sat, 12 Mar 2005 16:05:58 +0100 (CET) To: Joel Brobecker Cc: Jim Blandy , gdb-patches@sources.redhat.com Subject: Re: RFA: Don't use -Wuninitialized if CFLAGS omits -O References: <20050312090506.GU1156@adacore.com> From: Andreas Schwab X-Yow: ..Hmmm...This thing is really VIBRATING! ..It's getting WARM, too! Date: Sat, 12 Mar 2005 15:06:00 -0000 In-Reply-To: <20050312090506.GU1156@adacore.com> (Joel Brobecker's message of "Sat, 12 Mar 2005 01:05:06 -0800") Message-ID: User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-SW-Source: 2005-03/txt/msg00188.txt.bz2 Joel Brobecker writes: >> + # GCC supports -Wuninitialized only with -O or -On, n != 0. >> + if test x${CFLAGS+set} == xset; then > ^^ > I think the "==" should be "=", no? That's what "man test" documents. Yes, "=" is correct, "==" is implemented in some shells (like bash and ksh) as extension. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."