From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24426 invoked by alias); 12 Mar 2005 20:15:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24318 invoked from network); 12 Mar 2005 20:15:38 -0000 Received: from unknown (HELO priv-edtnes46.telusplanet.net) (199.185.220.240) by sourceware.org with SMTP; 12 Mar 2005 20:15:38 -0000 Received: from takamaka.act-europe.fr ([142.179.108.108]) by priv-edtnes46.telusplanet.net (InterMail vM.6.01.04.00 201-2131-118-20041027) with ESMTP id <20050312201533.PNKW28653.priv-edtnes46.telusplanet.net@takamaka.act-europe.fr>; Sat, 12 Mar 2005 13:15:33 -0700 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 5D1B747DC0; Sat, 12 Mar 2005 12:15:28 -0800 (PST) Date: Sat, 12 Mar 2005 20:15:00 -0000 From: Joel Brobecker To: Jim Blandy , gdb-patches@sources.redhat.com Subject: Re: RFA: Don't use -Wuninitialized if CFLAGS omits -O Message-ID: <20050312201528.GV1156@adacore.com> References: <20050312090506.GU1156@adacore.com> <20050312153235.GA11899@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050312153235.GA11899@nevyn.them.org> User-Agent: Mutt/1.4i X-SW-Source: 2005-03/txt/msg00190.txt.bz2 > > I think there is a slight problem that broke the build with non-GNU > > bourne shells. We have a build failure on our solaris 2.8 machine, > > for instance. Here is what I think the problem is: > > > > > + # GCC supports -Wuninitialized only with -O or -On, n != 0. > > > + if test x${CFLAGS+set} == xset; then > > ^^ > > I think the "==" should be "=", no? That's what "man test" documents. > > But I've never been a shell guru... > > Yes, that's right. Would you mind fixing this? Sure, wildo later today. -- Joel