Re: [PATCH v3 6/6] gdb/solib: C++ify solib_ops

[Tom de Vries <tdevries@suse.de>]

On 6/28/25 07:25, Simon Marchi wrote:
> 
> 
> On 2025-06-27 18:46, Thiago Jung Bauermann wrote:
>> Tom de Vries <tdevries@suse.de> writes:
>>
>>> On 6/26/25 20:04, Simon Marchi wrote:
>>>>    I will push the series shortly, when I'm done
>>>> addressing these comments.
>>>
>>> I did a mingw cross build from trunk, and ran into:
>>> ...
>>> /usr/lib64/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld:
>>> arch-utils.o:arch-utils.c:(.rdata$.refptr._Z21make_target_solib_opsv[.refptr._Z21make_target_solib_opsv]+0x0):
>>> undefined reference to `make_target_solib_ops()'
>>> collect2: error: ld returned 1 exit status
>>> make[1]: *** [Makefile:2253: gdb.exe] Error 1
>>> make[1]: Leaving directory '/data/vries/w/build/gdb'
>>> make: *** [Makefile:11391: all-gdb] Error 2
>>> $
>>> ...
>>>
>>> I suppose due to this commit.
>>
>> I'm also seeing it on a native build with FreeBSD on aarch64:
>>
>>    CXXLD  gdb
>> ld: error: undefined symbol: make_target_solib_ops()
>>>>> referenced by dicos-tdep.c:30 (/home/bauermann/src/binutils-gdb-wt/gdb/dicos-tdep.c:30)
>>>>>                dicos-tdep.o:(dicos_init_abi(gdbarch*))
>>>>> referenced by dicos-tdep.c:30 (/home/bauermann/src/binutils-gdb-wt/gdb/dicos-tdep.c:30)
>>>>>                dicos-tdep.o:(dicos_init_abi(gdbarch*))
>>>>> referenced by gdbarch-gen.c:160 (/home/bauermann/src/binutils-gdb-wt/gdb/gdbarch-gen.c:160)
>>>>>                arch-utils.o:(gdbarch::gdbarch())
>>>>> referenced 1 more times
>> c++: error: linker command failed with exit code 1 (use -v to see invocation)
>> gmake[2]: *** [Makefile:2253: gdb] Error 1
>>
> 
> Sorry about that.  Unfortunately, I didn't manage to reproduce.  I
> tried:
> 
>   - a native build on FreeBSD/amd64
>   - a native build on FreeBSD/amd64 --enable-targets=all
>   - a cross-build for mingw64 on Linux
> 
> What I don't understand from your logs is that make_target_solib_ops is
> defined in solib-target.c, which is always included in the build
> (solib-target.c is specified in COMMON_SFILES, in gdb/Makefile.in).  Do
> you see solib-target.c being compiled in these builds?
> 

Hi Simon,

I see it being compiled and included in the link line.

I've attached the build log to a PR I've filed for this issue (

https://sourceware.org/bugzilla/show_bug.cgi?id=33118 ).

Thanks,
- Tom

> Simon