Re: [PATCH v3 1/6] gdb/testsuite: check that "info shared" and "info linker-namespaces" before running don't crash

[Pedro Alves <pedro@palves.net>]

On 2025-06-16 20:32, Simon Marchi wrote:
> This patch is new in v3.
> 
> While writing my solib_ops C++ification series, I broke this, and it
> didn't seem to be caught by the testsuite.  Add a test for those.
> 
> The exact message for "info linker-namespaces" varies depending on the
> solib_ops of the target architecture (whether ops->num_active_namespaces
> is nullptr or not).  For now, just accept any message (a crash will
> still be caught).  A later patch in this series will make the message
> consistent and update this test.
> 
> Change-Id: I6bce2ff317447bbf321fc9cbd2d42c3dcea0c683
> ---
>  gdb/testsuite/gdb.base/dlmopen-ns-ids.exp | 5 +++++
>  gdb/testsuite/gdb.base/info-shared.exp    | 3 +++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/gdb/testsuite/gdb.base/dlmopen-ns-ids.exp b/gdb/testsuite/gdb.base/dlmopen-ns-ids.exp
> index 94b4a6e50bcf..8613056a7c8b 100644
> --- a/gdb/testsuite/gdb.base/dlmopen-ns-ids.exp
> +++ b/gdb/testsuite/gdb.base/dlmopen-ns-ids.exp
> @@ -169,6 +169,11 @@ proc_with_prefix test_conv_vars {} {
>  proc test_info_linker_namespaces {} {
>      clean_restart $::binfile
>  
> +    # Check that "info linker-namespaces" while the inferior is not running
> +    # doesn't crash.
> +    gdb_test "info linker-namespaces" ".*" \

You can write "" instead of ".*".  It'd be the same, a leading ".*" is already implied.

Otherwise LGTM.

Approved-By: Pedro Alves <pedro@palves.net>