Re: [PATCH v3 5/6] gdb/progspace: add solib_ops pointer in program_space

[Simon Marchi <simark@simark.ca>]

On 6/18/25 7:51 AM, Guinevere Larsen wrote:
> On 6/17/25 5:33 PM, Simon Marchi wrote:
>>> Thanks for working on this series! I have one very minor nit in this patch, but with that fixes, you can feel free to add my review tag
>>>
>>> Reviewed-By: Guinevere Larsen <guinevere@redhat.com>
>>>
>>> Feel free to add it to patches 1-4 as well, as I looked over them and they all LGTM. I still don't feel qualified to offer it for patch 6, though.
>> Thank you!
>>
>> Given your review, I plan to push this series probably tomorrow.  You
>> can start rebasing and adjusting your series on top, and then I can
>> hopefully review it this week (note that I'm off this Friday, so it
>> would have to be Thursday max).
> 
> I'll rebase and try to get it ready to send to the list by tomorrow, but I'll also go on vacation starting friday and only return July 7th, so if that series gets approved before GDB 17 branches, I'll need someone to push it for me.

Actually, which patches of my series would be useful to you?  Would it
be sufficient to merge patches 1 to 3, or 1 to 4?  I think they are
relatively low-risk, compared to the last two.  It feels safer to merge
the last two just after the GDB 17 branching, so that they have more
time to get tested in master.

Simon