Re: [PATCH v3 6/6] gdb/solib: C++ify solib_ops

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Tom de Vries <tdevries@suse.de> writes:

> On 6/26/25 20:04, Simon Marchi wrote:
>>   I will push the series shortly, when I'm done
>> addressing these comments.
>
> I did a mingw cross build from trunk, and ran into:
> ...
> /usr/lib64/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld:
> arch-utils.o:arch-utils.c:(.rdata$.refptr._Z21make_target_solib_opsv[.refptr._Z21make_target_solib_opsv]+0x0):
> undefined reference to `make_target_solib_ops()'
> collect2: error: ld returned 1 exit status
> make[1]: *** [Makefile:2253: gdb.exe] Error 1
> make[1]: Leaving directory '/data/vries/w/build/gdb'
> make: *** [Makefile:11391: all-gdb] Error 2
> $
> ...
>
> I suppose due to this commit.

I'm also seeing it on a native build with FreeBSD on aarch64:

  CXXLD  gdb
ld: error: undefined symbol: make_target_solib_ops()
>>> referenced by dicos-tdep.c:30 (/home/bauermann/src/binutils-gdb-wt/gdb/dicos-tdep.c:30)
>>>               dicos-tdep.o:(dicos_init_abi(gdbarch*))
>>> referenced by dicos-tdep.c:30 (/home/bauermann/src/binutils-gdb-wt/gdb/dicos-tdep.c:30)
>>>               dicos-tdep.o:(dicos_init_abi(gdbarch*))
>>> referenced by gdbarch-gen.c:160 (/home/bauermann/src/binutils-gdb-wt/gdb/gdbarch-gen.c:160)
>>>               arch-utils.o:(gdbarch::gdbarch())
>>> referenced 1 more times
c++: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[2]: *** [Makefile:2253: gdb] Error 1

-- 
Thiago