From: Pedro Alves <pedro@palves.net>
To: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3 2/6] gdb/solib: fix formatting of "info linker-namespaces" error message
Date: Fri, 20 Jun 2025 19:12:27 +0100 [thread overview]
Message-ID: <083adb1c-55b6-4cb2-836a-897b250d808b@palves.net> (raw)
In-Reply-To: <20250616193443.16703-2-simon.marchi@efficios.com>
On 2025-06-16 20:33, Simon Marchi wrote:
> This patch is new in v3.
>
> Add spaces after the first period and add a period at the end, resulting
> in:
>
> (gdb) info linker-namespaces
> ❌️ Current inferior does not support linker namespaces. Use "info sharedlibrary" instead.
>
> Change-Id: Ib3f1647cedcdb68852a3c63df26ea3e6f791b1b1
> ---
> gdb/solib.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/solib.c b/gdb/solib.c
> index 7721fd673ae3..90e7b906222c 100644
> --- a/gdb/solib.c
> +++ b/gdb/solib.c
> @@ -1163,8 +1163,8 @@ info_linker_namespace_command (const char *pattern, int from_tty)
> /* This command only really makes sense for inferiors that support
> linker namespaces, so we can leave early. */
> if (ops->num_active_namespaces == nullptr)
> - error (_("Current inferior does not support linker namespaces." \
> - "Use \"info sharedlibrary\" instead"));
> + error (_("Current inferior does not support linker namespaces. " \
> + "Use \"info sharedlibrary\" instead."));
>
You could remove the useless continuation backslash too, while at it.
Approved-By: Pedro Alves <pedro@palves.net>
next prev parent reply other threads:[~2025-06-20 18:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 19:32 [PATCH v3 1/6] gdb/testsuite: check that "info shared" and "info linker-namespaces" before running don't crash Simon Marchi
2025-06-16 19:33 ` [PATCH v3 2/6] gdb/solib: fix formatting of "info linker-namespaces" error message Simon Marchi
2025-06-20 18:12 ` Pedro Alves [this message]
2025-06-26 17:35 ` Simon Marchi
2025-06-16 19:33 ` [PATCH v3 3/6] gdb/solib: add solib -> solib_ops backlink Simon Marchi
2025-06-20 18:17 ` Pedro Alves
2025-06-16 19:33 ` [PATCH v3 4/6] gdb/solib: use solib::ops for operations that concern a single solib Simon Marchi
2025-06-20 18:17 ` Pedro Alves
2025-06-16 19:33 ` [PATCH v3 5/6] gdb/progspace: add solib_ops pointer in program_space Simon Marchi
2025-06-17 19:45 ` Guinevere Larsen
2025-06-17 20:33 ` Simon Marchi
2025-06-18 11:51 ` Guinevere Larsen
2025-06-18 14:43 ` Simon Marchi
2025-06-18 15:01 ` Guinevere Larsen
2025-06-20 18:19 ` Pedro Alves
2025-06-26 17:37 ` Simon Marchi
2025-09-02 14:49 ` Tom de Vries
2025-09-02 16:05 ` Simon Marchi
2025-09-02 16:34 ` Tom de Vries
2025-06-16 19:33 ` [PATCH v3 6/6] gdb/solib: C++ify solib_ops Simon Marchi
2025-06-20 18:20 ` Pedro Alves
2025-06-26 18:04 ` Simon Marchi
2025-06-27 22:04 ` Tom de Vries
2025-06-27 22:46 ` Thiago Jung Bauermann
2025-06-28 5:25 ` Simon Marchi
2025-06-28 6:27 ` Tom de Vries
2025-06-20 18:12 ` [PATCH v3 1/6] gdb/testsuite: check that "info shared" and "info linker-namespaces" before running don't crash Pedro Alves
2025-06-26 17:30 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=083adb1c-55b6-4cb2-836a-897b250d808b@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox