From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id k6bNHBWrVWjBTBYAWB0awg (envelope-from ) for ; Fri, 20 Jun 2025 14:40:21 -0400 Received: by simark.ca (Postfix, from userid 112) id 65C681E11C; Fri, 20 Jun 2025 14:40:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E3EBA1E089 for ; Fri, 20 Jun 2025 14:40:20 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 755F23A5F719 for ; Fri, 20 Jun 2025 18:25:29 +0000 (GMT) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by sourceware.org (Postfix) with ESMTPS id 6E6893838A2A for ; Fri, 20 Jun 2025 18:12:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6E6893838A2A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6E6893838A2A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750443151; cv=none; b=HrlPof6EH9nlZcxmssy3k/mkjj5626fjXQ3jWsYw01lhBs8qdK9YU9buB7ij/loE3U+IrOjTNCEiNss0oDqIFoJDrpGbS2PrC2lQjsiZQ8oOYKNUBidwS88IDOC6huveoYshEgBB+VsyuecasRh3cD6pp7zDY7GzU/xIMFmfTeQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750443151; c=relaxed/simple; bh=ZguTTJQ8Qukq+crrePD4vWs+92QL9dDZe57deFTQetQ=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=bqZWnP4wSTIXqrKnbpfOeaySP6HpqL64RIVIpGXRHc8UJJ/hP95k9uyBXU92GEqevA0kBABY1HZpAgd6fRd7kpbvO/FkWoayqm6p0DfiCF53UOqOJ0LkAY0/EHWNUYl/YeNn1fzMPg6W+WzBq+z3JoXrMDortWuWwVmKe8T1qlE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-450dd065828so15895135e9.2 for ; Fri, 20 Jun 2025 11:12:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750443150; x=1751047950; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=esDdkHaGEbRPq7Q8UozY+XHyXFvI3P0SG9x2siRfPhY=; b=VKXFtqytAlnT89l5I9gE/o6LqWlYDZm0exy9aneaj6T3QsK+P8lfKD8HOf77tlyTdw avUBjjT0ERyR75ZmigTrXg1ClSwrYj+VJRz4y5jxM5KadKVeI379xeKCldylJj29LZbl b2/DRpf0Sr/FGKuHwwWZBORsem2a9ZjvxPHn9p7uqRyslyRhzIAHKgqVSAPVhPJ0wjfM aaGHe77Rd+kF1kreV3A95CYYFQCayGaloAWdyAw+wYie3ltu59FSxQ16niuJPKEKn0iT IoOnQT2hU8wGaCXITLev3HAB4Udk+LUwUnRPU5ctFQ1AOONvbmQIk47EQ4FQW1GVPAzJ KF1g== X-Forwarded-Encrypted: i=1; AJvYcCWEbIuxUdqHsR/T8d2BlHobQmGpWCOCL9Unt21KrtZfpJ9/MysAhwh8MEqjMolc1i7xHI0PgTIDYtTpuA==@sourceware.org X-Gm-Message-State: AOJu0YzOnmMMIKAkqhej4jQ1Zymf2oV8LVGBK0MwhA4nhjv9NqbH6vUa 0uNnqATQ9TqRmlBN9RvE6441Tozw2TCH61HZCUlcpmrFYFZiA2My3dDk406P+JuP X-Gm-Gg: ASbGncso4wq0qag/FctezIsxKCyjPlLSasrAVY91cDxmGBuMcR9lOYqCc7WGbrDJ8vO WOVRgYe0MA76eQ9kgNX1LsGOhRJp4SIq59ZZv5JGKf8BMk1sYrfUFQGw0O7STQzcPwtChh7a4/r lw5WWTPWAemE9McdageIu/r4AocPV1v717oVtXM57mszv0W3+NHctv5n7m7mVKNryZl92u8W06H RdtLP/izF2cw/hLF/yJqzR3Qyfo2mYvCLmvrhaRfOSGMQ1j7Jyj/ZKbFxv+YrgMnpNo4nY4aMmG J/1YrsurzCqhv6gmdEcZu9uTAcHRpeeBZsS0Pp5cIlUWrFgXThYItklPPoCXwILZ+JVnicqNKsK je6g7CAHrwa9ARWVugEbMzWuK4DRGig== X-Google-Smtp-Source: AGHT+IEcbK+DbWeizWqcIHVXOu2fkU182jZOAzGQTXpD5PVODE0fHSqV2CR2KOz3tOZWOWlNgxpKFA== X-Received: by 2002:a05:6000:4a02:b0:3a5:783f:5297 with SMTP id ffacd0b85a97d-3a6d12d9187mr3985605f8f.35.1750443150080; Fri, 20 Jun 2025 11:12:30 -0700 (PDT) Received: from ?IPV6:2001:8a0:fac3:6d00:afcc:85d3:71a5:7570? ([2001:8a0:fac3:6d00:afcc:85d3:71a5:7570]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d0f10a4dsm2636043f8f.8.2025.06.20.11.12.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Jun 2025 11:12:29 -0700 (PDT) Message-ID: <083adb1c-55b6-4cb2-836a-897b250d808b@palves.net> Date: Fri, 20 Jun 2025 19:12:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/6] gdb/solib: fix formatting of "info linker-namespaces" error message To: Simon Marchi , gdb-patches@sourceware.org References: <20250616193443.16703-1-simon.marchi@efficios.com> <20250616193443.16703-2-simon.marchi@efficios.com> From: Pedro Alves Content-Language: en-US In-Reply-To: <20250616193443.16703-2-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-06-16 20:33, Simon Marchi wrote: > This patch is new in v3. > > Add spaces after the first period and add a period at the end, resulting > in: > > (gdb) info linker-namespaces > ❌️ Current inferior does not support linker namespaces. Use "info sharedlibrary" instead. > > Change-Id: Ib3f1647cedcdb68852a3c63df26ea3e6f791b1b1 > --- > gdb/solib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/solib.c b/gdb/solib.c > index 7721fd673ae3..90e7b906222c 100644 > --- a/gdb/solib.c > +++ b/gdb/solib.c > @@ -1163,8 +1163,8 @@ info_linker_namespace_command (const char *pattern, int from_tty) > /* This command only really makes sense for inferiors that support > linker namespaces, so we can leave early. */ > if (ops->num_active_namespaces == nullptr) > - error (_("Current inferior does not support linker namespaces." \ > - "Use \"info sharedlibrary\" instead")); > + error (_("Current inferior does not support linker namespaces. " \ > + "Use \"info sharedlibrary\" instead.")); > You could remove the useless continuation backslash too, while at it. Approved-By: Pedro Alves