Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Simon Marchi <simark@simark.ca>,
	Simon Marchi <simon.marchi@efficios.com>,
	gdb-patches@sourceware.org
Subject: Re: [PATCH v3 5/6] gdb/progspace: add solib_ops pointer in program_space
Date: Tue, 2 Sep 2025 18:34:56 +0200	[thread overview]
Message-ID: <b950d27d-11aa-4916-9fa7-37cb50b89258@suse.de> (raw)
In-Reply-To: <c78aa387-2351-4ac4-b201-04058f459111@simark.ca>

On 9/2/25 18:05, Simon Marchi wrote:
> On 9/2/25 10:49 AM, Tom de Vries wrote:
>> On 6/16/25 21:33, Simon Marchi wrote:
>>> +     The solib provider must be unset prior to call this method.  */
>>> +  void set_solib_ops (const struct solib_ops &ops)
>>> +  {
>>> +    gdb_assert (m_solib_ops == nullptr);
>>> +    m_solib_ops = &ops;
>>> +  };
>>
>> This assert triggers with test-case gdb.server/extended-remote-restart.exp and target board native-extended-gdbserver, starting with the commit that introduced it.
>>
>> I've filed a PR about this ( https://sourceware.org/bugzilla/show_bug.cgi?id=33357 ).
>>
>> Thanks,
>> - Tom
> 
> This is fixed by this pending series, which I had forgotten about:
> 
> https://inbox.sourceware.org/gdb-patches/20250708205619.3582933-1-simon.marchi@polymtl.ca/
> 
> Can you can confirm that it fixes the issue on your side?

It does.

After applying the series and rebuilding, we're back to the gdbserver 
assertion failure mentioned in the PR:
...
		=== gdb Summary ===

# of unexpected core files	1
# of expected passes		28
...

Thanks,
- Tom

  reply	other threads:[~2025-09-02 16:36 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-16 19:32 [PATCH v3 1/6] gdb/testsuite: check that "info shared" and "info linker-namespaces" before running don't crash Simon Marchi
2025-06-16 19:33 ` [PATCH v3 2/6] gdb/solib: fix formatting of "info linker-namespaces" error message Simon Marchi
2025-06-20 18:12   ` Pedro Alves
2025-06-26 17:35     ` Simon Marchi
2025-06-16 19:33 ` [PATCH v3 3/6] gdb/solib: add solib -> solib_ops backlink Simon Marchi
2025-06-20 18:17   ` Pedro Alves
2025-06-16 19:33 ` [PATCH v3 4/6] gdb/solib: use solib::ops for operations that concern a single solib Simon Marchi
2025-06-20 18:17   ` Pedro Alves
2025-06-16 19:33 ` [PATCH v3 5/6] gdb/progspace: add solib_ops pointer in program_space Simon Marchi
2025-06-17 19:45   ` Guinevere Larsen
2025-06-17 20:33     ` Simon Marchi
2025-06-18 11:51       ` Guinevere Larsen
2025-06-18 14:43         ` Simon Marchi
2025-06-18 15:01           ` Guinevere Larsen
2025-06-20 18:19   ` Pedro Alves
2025-06-26 17:37     ` Simon Marchi
2025-09-02 14:49   ` Tom de Vries
2025-09-02 16:05     ` Simon Marchi
2025-09-02 16:34       ` Tom de Vries [this message]
2025-06-16 19:33 ` [PATCH v3 6/6] gdb/solib: C++ify solib_ops Simon Marchi
2025-06-20 18:20   ` Pedro Alves
2025-06-26 18:04     ` Simon Marchi
2025-06-27 22:04       ` Tom de Vries
2025-06-27 22:46         ` Thiago Jung Bauermann
2025-06-28  5:25           ` Simon Marchi
2025-06-28  6:27             ` Tom de Vries
2025-06-20 18:12 ` [PATCH v3 1/6] gdb/testsuite: check that "info shared" and "info linker-namespaces" before running don't crash Pedro Alves
2025-06-26 17:30   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b950d27d-11aa-4916-9fa7-37cb50b89258@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    --cc=simon.marchi@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox