Re: [PATCH v3 5/6] gdb/progspace: add solib_ops pointer in program_space

[Pedro Alves <pedro@palves.net>]

On 2025-06-16 20:33, Simon Marchi wrote:
> New in v3:
> 
>  - add some ops nullptr checks in print_solib_list_table and
>    info_linker_namespace_command
> 
> The subsequent C++ification patch in this series will allocate one
> instance of solib_ops per program space.  That instance will be held in
> struct program_space.  As a small step towards this, add an `solib_ops
> *` field to `struct program_space`.  This field represents the solib_ops
> currently used to manage the solibs in that program space.  Initialize
> it with the result of `gdbarch_so_ops` in `post_create_inferior`, and
> use it whenever we need to do some solib stuff, rather than using
> `gdbarch_so_ops` directly.
> 
> The difficulty here is knowing when exactly to set and unset the solib
> ops.  What I have here passes the testsuite on Linux, but with more
> testing we will probably discover more spots where it's needed.

One important detail is keeping the solibs listed after the inferior exits.
This is so the user can set breakpoints in shared library symbols for the
next re-run.

Your patches preserve that, which is good.  I don't recall off hand if there's
a testcase ensure it.

Tiny nit below.  Other than that:

Approved-By: Pedro Alves <pedro@palves.net>

> diff --git a/gdb/progspace.h b/gdb/progspace.h
> index 5e5d5edd9b4b..abb448195d74 100644
> --- a/gdb/progspace.h
> +++ b/gdb/progspace.h
> @@ -231,6 +231,23 @@ struct program_space
>       is outside all objfiles in this progspace.  */
>    struct objfile *objfile_for_address (CORE_ADDR address);
>  
> +  /* Set this program space's solib provider.
> +
> +     The solib provider must be unset prior to call this method.  */


"prior to call" -> prior to calling"



> +  void set_solib_ops (const struct solib_ops &ops)
> +  {
> +    gdb_assert (m_solib_ops == nullptr);
> +    m_solib_ops = &ops;
> +  };
> +