From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sdrNOmGrVWgHTRYAWB0awg (envelope-from ) for ; Fri, 20 Jun 2025 14:41:37 -0400 Received: by simark.ca (Postfix, from userid 112) id DF1F31E11C; Fri, 20 Jun 2025 14:41:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 569D11E089 for ; Fri, 20 Jun 2025 14:41:37 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3D3D93AA5302 for ; Fri, 20 Jun 2025 18:26:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3D3D93AA5302 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by sourceware.org (Postfix) with ESMTPS id 18533388EC0E for ; Fri, 20 Jun 2025 18:12:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 18533388EC0E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 18533388EC0E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750443134; cv=none; b=XA1/FQhsZG+XmtHNwayClayL4BZ1ZjxWcG5AS8246vsOMrixKEkIsGonOSJDfW5Kf9aioBVkfStWnV4Nn4enWrLRxGRxcdOOw3kOcm3XsK4UZxqC5u0U28J4nzY1DyAETDe8UGsd6s3C8hpLtM38wydLITKuOWZwtql3PjMHJ78= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750443134; c=relaxed/simple; bh=o9MEdbfZdB5qeTBz2XPlUScK//jumplC3C0mXx01ekc=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=g78aZra1tsecAjItak3/dbKpoIWPm+wSqoBeHjSFeNCg8scZkg6U4YVM1b7D/O7C+HyZwMyDQE9dARGKBm9UfclXqBUpIBDrNwiFum0UoKgVRCmyyv1OlugFSdiAv7OYsiAQkUiFg3bgPPcGk099fBXMaT8ItzTPKSgOOgRv/Is= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 18533388EC0E Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-450cf0120cdso17364975e9.2 for ; Fri, 20 Jun 2025 11:12:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750443133; x=1751047933; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LwLCNzz3ZPWH8MjwAKZImrN0Pus9ge69bvkaPQBMsYk=; b=unuHGZz+8oSZYXene1tLO5jhqK15JuYpP6DYptsm8pggJZDvUFW1mn/WzrlaehMeXW D3+aM9jbia3JXa7kt3qbSlt1iBDkqBTL/uz1Z0ibjaBuuy9NJayVL8hCqESXkvRDJoyc dgsktJpEicoUR6eDu7icGDSrKhQ2z+8VhSTih3MXrNOsce4x0T9XhOd1zSY9MwKLEQNj Ldhhxp1uJIQlweScf10ky81Avkr257DgO2NaX3n+TZsAvhyjB28jg2FlVC1KPtlD8GRg OYem+/fpeOtPxS/xxH5/AoM4mrHo/aFiazdbMOpMSBZ9EJwuQciA4CUUstZ/TQ76C3C2 CyKw== X-Forwarded-Encrypted: i=1; AJvYcCV8/ttqCh/TiqKRoperGc/Bgwh8SAUglXOO39zEcOqH1Z4bogClI9f9T4gE7LcRRPQwyPL97dz9oWK9ew==@sourceware.org X-Gm-Message-State: AOJu0YzliRa5aHDyp++0fP1d9CUg34SHbd50YhvG2OvzOJodC5LkyPqI YSAaOd9nJH13+Xy73LShIq4pv4+ds6dsiyi+QFeIgPOlXuTygjeOTJtJJhdGBngu X-Gm-Gg: ASbGncvlL3tymCgRmzIsHGgeWwgKKkip+qvVLi2YfyRMkBPb9qZPwIcOI1gJPzcVK9v I9HHNaeVkl+goVJtuBZiHCYOIwlE+2+CLbtSi4scJIp/387pfmmp4i5qjtLS+qtyd6/d80Pw21y GsirjJrur+ABYVihPImIpedZkhEkAL1WFUtzFltU5AYFe83aBwa3MWvNNR+3GztPt3WU+fEIslA rr8I0rdaFBDEoPcUqXtxHdF1Hj6pKeUQjFTspUi47f1P/p8FM7HmEJAArmxeNTmtE8XIuwkWM8J NopM7bMnpU0PR6x1ZsOYQy0nIsTMcHST679oc4+gWFqrARqIXtHgESDbYH8m6Gv81x+7HkeuxvO 8RjvfHCGmkTRJx58IK9kNb/kF9Lla6A== X-Google-Smtp-Source: AGHT+IHREWztbODw5sBTZcIfH0xhe9uMVu5wCZFxTf5tQdVc8RmNJK3jhnkOwlr6gTsQXhG4fDkwaQ== X-Received: by 2002:a05:600c:3513:b0:450:cde3:f266 with SMTP id 5b1f17b1804b1-453659cb94bmr34516405e9.22.1750443132571; Fri, 20 Jun 2025 11:12:12 -0700 (PDT) Received: from ?IPV6:2001:8a0:fac3:6d00:afcc:85d3:71a5:7570? ([2001:8a0:fac3:6d00:afcc:85d3:71a5:7570]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d0f187a5sm2734138f8f.34.2025.06.20.11.12.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Jun 2025 11:12:12 -0700 (PDT) Message-ID: <2755ce98-0513-4138-bea5-b6e6f035bcae@palves.net> Date: Fri, 20 Jun 2025 19:12:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/6] gdb/testsuite: check that "info shared" and "info linker-namespaces" before running don't crash To: Simon Marchi , gdb-patches@sourceware.org References: <20250616193443.16703-1-simon.marchi@efficios.com> From: Pedro Alves Content-Language: en-US In-Reply-To: <20250616193443.16703-1-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-06-16 20:32, Simon Marchi wrote: > This patch is new in v3. > > While writing my solib_ops C++ification series, I broke this, and it > didn't seem to be caught by the testsuite. Add a test for those. > > The exact message for "info linker-namespaces" varies depending on the > solib_ops of the target architecture (whether ops->num_active_namespaces > is nullptr or not). For now, just accept any message (a crash will > still be caught). A later patch in this series will make the message > consistent and update this test. > > Change-Id: I6bce2ff317447bbf321fc9cbd2d42c3dcea0c683 > --- > gdb/testsuite/gdb.base/dlmopen-ns-ids.exp | 5 +++++ > gdb/testsuite/gdb.base/info-shared.exp | 3 +++ > 2 files changed, 8 insertions(+) > > diff --git a/gdb/testsuite/gdb.base/dlmopen-ns-ids.exp b/gdb/testsuite/gdb.base/dlmopen-ns-ids.exp > index 94b4a6e50bcf..8613056a7c8b 100644 > --- a/gdb/testsuite/gdb.base/dlmopen-ns-ids.exp > +++ b/gdb/testsuite/gdb.base/dlmopen-ns-ids.exp > @@ -169,6 +169,11 @@ proc_with_prefix test_conv_vars {} { > proc test_info_linker_namespaces {} { > clean_restart $::binfile > > + # Check that "info linker-namespaces" while the inferior is not running > + # doesn't crash. > + gdb_test "info linker-namespaces" ".*" \ You can write "" instead of ".*". It'd be the same, a leading ".*" is already implied. Otherwise LGTM. Approved-By: Pedro Alves