From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mDeFHoeLX2hxNiMAWB0awg (envelope-from ) for ; Sat, 28 Jun 2025 02:28:23 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=s3T9u6jt; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=inVRIYE6; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=s3T9u6jt; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=inVRIYE6; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 786761E11E; Sat, 28 Jun 2025 02:28:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D4DAF1E089 for ; Sat, 28 Jun 2025 02:28:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 52A71385C6FF for ; Sat, 28 Jun 2025 06:28:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 52A71385C6FF Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=s3T9u6jt; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=inVRIYE6; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=s3T9u6jt; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=inVRIYE6 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 95E72385781B for ; Sat, 28 Jun 2025 06:27:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 95E72385781B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 95E72385781B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751092062; cv=none; b=C5k2Ef+J0anzvI9RjWB3tLPi72ZkEcvwDI4fPvM9+/SW9McXTsTDAZFVBBGuKidsYDzZ0/TtrZZiM7AGdtzBDNdkeOx4IDlc44qYueqZTXt8C3X+cH5BKNfciUg/qS6TYn0FLcwGSylOu8l0bGtxceFnTwPAdV2PVQCz9Zoq7KE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751092062; c=relaxed/simple; bh=YTGVX+HTZ3gnIxEfFGZUqt47XN/r+VCvWMhaA0qSlv8=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=Ni2GL9ceJX1u3CsfUmufkWjuvTKo0d7buf0cVUyDbYHwkt9rfXTIenjf+rs7FQPO1soFy9NwUyOeGZxjL/cp+Y+5S9hZUVSYOWo4wyuJtQhLFjcj2laBCS7ZevgvZgy/bPv0qz84retPQAQCdyOQaY9OTWTVMrGCPWcnTcTRwFo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 95E72385781B Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6C1571F38C; Sat, 28 Jun 2025 06:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751092061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D8CL79LmJPOPJLv1skF07qj6nIdQsGSSCkMENzHgERk=; b=s3T9u6jtR8FwJtiiiR1jYOyTu3GJi4dKpN1oduNanxnUj1riTGALMTs5d0tnZJEs1fGa96 pROx6BdQat31npftKtzAT6ngBZ+kQi69jyWYpgS5PhikzXP1VWqVC2zUl6Aef9ILX9wF9z vVoYqUxNwdO5obRXUA2KYtA5uW9t0lI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751092061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D8CL79LmJPOPJLv1skF07qj6nIdQsGSSCkMENzHgERk=; b=inVRIYE6LkDTxf/w8vb+iR5SA0M0WbY0M+dIn7ldA3OBI6s2nEnXP/PHDDmtDSX7V1KC5m ensf4gEWNUXkiuDA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=s3T9u6jt; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=inVRIYE6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751092061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D8CL79LmJPOPJLv1skF07qj6nIdQsGSSCkMENzHgERk=; b=s3T9u6jtR8FwJtiiiR1jYOyTu3GJi4dKpN1oduNanxnUj1riTGALMTs5d0tnZJEs1fGa96 pROx6BdQat31npftKtzAT6ngBZ+kQi69jyWYpgS5PhikzXP1VWqVC2zUl6Aef9ILX9wF9z vVoYqUxNwdO5obRXUA2KYtA5uW9t0lI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751092061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D8CL79LmJPOPJLv1skF07qj6nIdQsGSSCkMENzHgERk=; b=inVRIYE6LkDTxf/w8vb+iR5SA0M0WbY0M+dIn7ldA3OBI6s2nEnXP/PHDDmtDSX7V1KC5m ensf4gEWNUXkiuDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3C30A1379A; Sat, 28 Jun 2025 06:27:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XpXfDF2LX2j8PgAAD6G6ig (envelope-from ); Sat, 28 Jun 2025 06:27:41 +0000 Message-ID: Date: Sat, 28 Jun 2025 08:27:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/6] gdb/solib: C++ify solib_ops To: Simon Marchi , Thiago Jung Bauermann Cc: Pedro Alves , Simon Marchi , gdb-patches@sourceware.org References: <20250616193443.16703-1-simon.marchi@efficios.com> <20250616193443.16703-6-simon.marchi@efficios.com> <06dd119d-2789-4928-a651-9a8ca0567d84@simark.ca> <3cac674f-75fc-4674-a9e6-21447aabbea6@suse.de> <87ldpcby67.fsf@linaro.org> <2eb0f5ea-b11d-4e9d-8f94-e85a74a47bf9@simark.ca> Content-Language: en-US From: Tom de Vries In-Reply-To: <2eb0f5ea-b11d-4e9d-8f94-e85a74a47bf9@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 6C1571F38C X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:dkim,suse.de:email]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/28/25 07:25, Simon Marchi wrote: > > > On 2025-06-27 18:46, Thiago Jung Bauermann wrote: >> Tom de Vries writes: >> >>> On 6/26/25 20:04, Simon Marchi wrote: >>>> I will push the series shortly, when I'm done >>>> addressing these comments. >>> >>> I did a mingw cross build from trunk, and ran into: >>> ... >>> /usr/lib64/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld: >>> arch-utils.o:arch-utils.c:(.rdata$.refptr._Z21make_target_solib_opsv[.refptr._Z21make_target_solib_opsv]+0x0): >>> undefined reference to `make_target_solib_ops()' >>> collect2: error: ld returned 1 exit status >>> make[1]: *** [Makefile:2253: gdb.exe] Error 1 >>> make[1]: Leaving directory '/data/vries/w/build/gdb' >>> make: *** [Makefile:11391: all-gdb] Error 2 >>> $ >>> ... >>> >>> I suppose due to this commit. >> >> I'm also seeing it on a native build with FreeBSD on aarch64: >> >> CXXLD gdb >> ld: error: undefined symbol: make_target_solib_ops() >>>>> referenced by dicos-tdep.c:30 (/home/bauermann/src/binutils-gdb-wt/gdb/dicos-tdep.c:30) >>>>> dicos-tdep.o:(dicos_init_abi(gdbarch*)) >>>>> referenced by dicos-tdep.c:30 (/home/bauermann/src/binutils-gdb-wt/gdb/dicos-tdep.c:30) >>>>> dicos-tdep.o:(dicos_init_abi(gdbarch*)) >>>>> referenced by gdbarch-gen.c:160 (/home/bauermann/src/binutils-gdb-wt/gdb/gdbarch-gen.c:160) >>>>> arch-utils.o:(gdbarch::gdbarch()) >>>>> referenced 1 more times >> c++: error: linker command failed with exit code 1 (use -v to see invocation) >> gmake[2]: *** [Makefile:2253: gdb] Error 1 >> > > Sorry about that. Unfortunately, I didn't manage to reproduce. I > tried: > > - a native build on FreeBSD/amd64 > - a native build on FreeBSD/amd64 --enable-targets=all > - a cross-build for mingw64 on Linux > > What I don't understand from your logs is that make_target_solib_ops is > defined in solib-target.c, which is always included in the build > (solib-target.c is specified in COMMON_SFILES, in gdb/Makefile.in). Do > you see solib-target.c being compiled in these builds? > Hi Simon, I see it being compiled and included in the link line. I've attached the build log to a PR I've filed for this issue ( https://sourceware.org/bugzilla/show_bug.cgi?id=33118 ). Thanks, - Tom > Simon