Re: [PATCH 5/5 v7] Introduce show_debug_regs

[Doug Evans <dje@google.com>]

On Wed, Aug 13, 2014 at 2:56 AM, Gary Benson <gbenson@redhat.com> wrote:
> This commit adds a new global flag show_debug_regs to common-debug.h
> to replace the flag debug_hw_points used by gdbserver and by the
> Linux x86 and AArch64 ports, and to replace the flag maint_show_dr
> used by the Linux MIPS port.
>
> gdb/
> 2014-08-13  Gary Benson  <gbenson@redhat.com>
>
>         * common/common-debug.h (show_debug_regs): Declare.
>         * common/common-debug.c (show_debug_regs): Define.
>         * aarch64-linux-nat.c (debug_hw_points): Don't define.  Replace
>         all uses with show_debug_regs.  Replace all uses that considered
>         debug_hw_points as a multi-value integer with straight boolean
>         uses.
>         * i386-nat.c (debug_hw_points): Don't define.  Replace all uses
>         with show_debug_regs.
>         * nat/i386-dregs.c (debug_hw_points): Don't declare.  Replace
>         all uses with show_debug_regs.
>         * mips-linux-nat.c (maint_show_dr): Don't define.  Replace all
>         uses with show_debug_regs.
>
> gdb/gdbserver/
> 2014-08-13  Gary Benson  <gbenson@redhat.com>
>
>         * server.h (debug_hw_points): Don't declare.
>         * server.c (debug_hw_points): Don't define.  Replace all uses
>         with show_debug_regs.
>         * linux-aarch64-low.c (debug_hw_points): Don't define.  Replace
>         all uses with show_debug_regs.

I'd let this one sit for awhile longer, to give others a bit more time
to comment if they want.