From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19229 invoked by alias); 18 Aug 2014 16:40:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19212 invoked by uid 89); 18 Aug 2014 16:40:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f179.google.com Received: from mail-vc0-f179.google.com (HELO mail-vc0-f179.google.com) (209.85.220.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 18 Aug 2014 16:40:33 +0000 Received: by mail-vc0-f179.google.com with SMTP id hq11so6100254vcb.10 for ; Mon, 18 Aug 2014 09:40:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=JqUbiAfS/2I9R2DpMVleym1C59EzqCp3XKhwQGSNNDg=; b=MSTjIzepmM18cCIejdLZWu0M8Xm1nPi3LEyoruhKdkgtF88s67WKibK8FmJVAULl61 HDutFah7zhQ0YHL6yBU4KvH7hQm1vmGTzomZ2/kvQ3sUw9WJt5cXRLA0uY2z0eTltnM9 TgZxP1A/m2A4lz3FBlZ3qhGm5QNVl9ujO4mGmoIncYU+LWWqXxoMn93beIIk/aSDVTJ8 L9/oSY8qN/cUpaMMN9NrP/ZpJFjQMZC3z3AF+/HJ3pvzg0K8ZEhuCX4PFLiao3cIBNzR oa/0+OlsBoNm+Nl+uZwDrYWoic33DfDCIyHwm6PdhWrJaraUexlaAfkXyli31BayVGMx Oygg== X-Gm-Message-State: ALoCoQn5LGQ67HQ2bOQ9lfuqKu9noR2UuWzJPOJYy4pM5TO1dtz3JFrbuHu4AO3bIVPXx/SIF2kS MIME-Version: 1.0 X-Received: by 10.220.168.210 with SMTP id v18mr25655934vcy.3.1408380030994; Mon, 18 Aug 2014 09:40:30 -0700 (PDT) Received: by 10.52.136.203 with HTTP; Mon, 18 Aug 2014 09:40:30 -0700 (PDT) In-Reply-To: <1407923779-22149-6-git-send-email-gbenson@redhat.com> References: <1407923779-22149-1-git-send-email-gbenson@redhat.com> <1407923779-22149-6-git-send-email-gbenson@redhat.com> Date: Mon, 18 Aug 2014 16:40:00 -0000 Message-ID: Subject: Re: [PATCH 5/5 v7] Introduce show_debug_regs From: Doug Evans To: Gary Benson Cc: gdb-patches , Pedro Alves Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00308.txt.bz2 On Wed, Aug 13, 2014 at 2:56 AM, Gary Benson wrote: > This commit adds a new global flag show_debug_regs to common-debug.h > to replace the flag debug_hw_points used by gdbserver and by the > Linux x86 and AArch64 ports, and to replace the flag maint_show_dr > used by the Linux MIPS port. > > gdb/ > 2014-08-13 Gary Benson > > * common/common-debug.h (show_debug_regs): Declare. > * common/common-debug.c (show_debug_regs): Define. > * aarch64-linux-nat.c (debug_hw_points): Don't define. Replace > all uses with show_debug_regs. Replace all uses that considered > debug_hw_points as a multi-value integer with straight boolean > uses. > * i386-nat.c (debug_hw_points): Don't define. Replace all uses > with show_debug_regs. > * nat/i386-dregs.c (debug_hw_points): Don't declare. Replace > all uses with show_debug_regs. > * mips-linux-nat.c (maint_show_dr): Don't define. Replace all > uses with show_debug_regs. > > gdb/gdbserver/ > 2014-08-13 Gary Benson > > * server.h (debug_hw_points): Don't declare. > * server.c (debug_hw_points): Don't define. Replace all uses > with show_debug_regs. > * linux-aarch64-low.c (debug_hw_points): Don't define. Replace > all uses with show_debug_regs. I'd let this one sit for awhile longer, to give others a bit more time to comment if they want.