From: "Frank Ch. Eigler" <fche@redhat.com>
To: Gary Benson <gbenson@redhat.com>
Cc: Mike Frysinger <vapier@gentoo.org>,
Steve Ellcey <sellcey@mips.com>,
Doug Evans <dje@google.com>,
gdb-patches <gdb-patches@sourceware.org>,
Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH 4/5 v7] Introduce common-debug.h
Date: Wed, 20 Aug 2014 13:32:00 -0000 [thread overview]
Message-ID: <20140820133155.GB5363@redhat.com> (raw)
In-Reply-To: <20140820120934.GA26854@blade.nx>
Hi -
> > [...]
> > i'm fine with updating sim/common/sim-trace.h with that idea:
> > #define debug_printf sim_debug_printf
> > all the symbols coming out of the sim really should be namespaced
IMHO, names this generic should be avoided in *both* application (gdb)
and library (sim), lest another future library come & interfere later.
> Great. I can put together a patch if you like (or I can make the
> change, or you can... whatever's easiest!) I don't know much about
> SIM... is there a list to mail patches to? And, is its upstream
> repo the same as binutils+GDB or is it imported from somewhere else
> like libiberty?
sim is part of the binutils-gdb.git repo, patches here fine. The main
problem with testing the sim for changes like this is its inability to
easily build all targets, and its aggressive use of macros, which
makes it hard to know you've actually covered all the cases for a
symbol-rename.
- FChE
next prev parent reply other threads:[~2014-08-20 13:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 9:56 [PATCH 0/5 v7] Common code cleanups (first four, and one new) Gary Benson
2014-08-13 9:56 ` [PATCH 3/5 v7] Move print-utils.h to common-defs.h Gary Benson
2014-08-18 16:29 ` Doug Evans
2014-08-13 9:56 ` [PATCH 4/5 v7] Introduce common-debug.h Gary Benson
2014-08-18 16:38 ` Doug Evans
2014-08-19 9:12 ` Gary Benson
2014-08-19 23:22 ` Steve Ellcey
2014-08-20 8:53 ` Gary Benson
2014-08-20 9:42 ` Mike Frysinger
2014-08-20 12:09 ` Gary Benson
2014-08-20 13:32 ` Frank Ch. Eigler [this message]
2014-08-20 19:16 ` Gary Benson
2014-08-20 21:41 ` Frank Ch. Eigler
2014-08-20 21:58 ` Doug Evans
2014-08-20 21:58 ` Gary Benson
2014-08-20 22:48 ` Frank Ch. Eigler
2014-08-21 1:19 ` Mike Frysinger
2014-08-27 8:53 ` [PING PATCH] Rename SIM's debug_printf (Was: [PATCH 4/5 v7] Introduce common-debug.h) Gary Benson
2014-08-28 0:09 ` Frank Ch. Eigler
2014-08-28 13:31 ` Gary Benson
2014-08-20 15:32 ` [PATCH 4/5 v7] Introduce common-debug.h Mike Frysinger
2014-08-20 19:14 ` Gary Benson
2014-08-21 1:18 ` Mike Frysinger
2014-08-13 9:56 ` [PATCH 2/5 v7] Introduce common-types.h Gary Benson
2014-08-18 16:25 ` Doug Evans
2014-08-13 10:34 ` [PATCH 5/5 v7] Introduce show_debug_regs Gary Benson
2014-08-18 16:40 ` Doug Evans
2014-08-13 10:55 ` [PATCH 1/5 v7] Introduce common/errors.h Gary Benson
2014-08-18 16:20 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140820133155.GB5363@redhat.com \
--to=fche@redhat.com \
--cc=dje@google.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=sellcey@mips.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox