Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Gary Benson <gbenson@redhat.com>
Cc: Steve Ellcey <sellcey@mips.com>, Doug Evans <dje@google.com>,
	gdb-patches <gdb-patches@sourceware.org>,
	Pedro Alves <palves@redhat.com>,
	"Frank Ch. Eigler" <fche@redhat.com>
Subject: Re: [PATCH 4/5 v7] Introduce common-debug.h
Date: Wed, 20 Aug 2014 15:32:00 -0000	[thread overview]
Message-ID: <2738453.Usiax8h3c8@vapier> (raw)
In-Reply-To: <20140820120934.GA26854@blade.nx>

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

On Wed 20 Aug 2014 13:09:34 Gary Benson wrote:
> Mike Frysinger wrote:
> > On Wed 20 Aug 2014 09:52:43 Gary Benson wrote:
> > > Steve, you can probably work around this for now by adding:
> > >   #define debug_printf gdb_debug_printf
> > > 
> > > at the top of GDB's common/common-debug.h.  If SIM's debug_printf
> > > cannot be removed then maybe we will have to add some hack like
> > > this to GDB permanently.
> > 
> > i'm fine with updating sim/common/sim-trace.h with that idea:
> > #define debug_printf sim_debug_printf
> > 
> > all the symbols coming out of the sim really should be namespaced
> 
> Great.  I can put together a patch if you like (or I can make the
> change, or you can... whatever's easiest!)  I don't know much about
> SIM... is there a list to mail patches to?  And, is its upstream
> repo the same as binutils+GDB or is it imported from somewhere else
> like libiberty?

it would be great if you could put together the patch :).  sim patches go to 
the same place as gdb (same repo), and i can approve them when i see them.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2014-08-20 15:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-13  9:56 [PATCH 0/5 v7] Common code cleanups (first four, and one new) Gary Benson
2014-08-13  9:56 ` [PATCH 4/5 v7] Introduce common-debug.h Gary Benson
2014-08-18 16:38   ` Doug Evans
2014-08-19  9:12     ` Gary Benson
2014-08-19 23:22       ` Steve Ellcey
2014-08-20  8:53         ` Gary Benson
2014-08-20  9:42           ` Mike Frysinger
2014-08-20 12:09             ` Gary Benson
2014-08-20 13:32               ` Frank Ch. Eigler
2014-08-20 19:16                 ` Gary Benson
2014-08-20 21:41                   ` Frank Ch. Eigler
2014-08-20 21:58                     ` Doug Evans
2014-08-20 21:58                     ` Gary Benson
2014-08-20 22:48                       ` Frank Ch. Eigler
2014-08-21  1:19                         ` Mike Frysinger
2014-08-27  8:53                           ` [PING PATCH] Rename SIM's debug_printf (Was: [PATCH 4/5 v7] Introduce common-debug.h) Gary Benson
2014-08-28  0:09                             ` Frank Ch. Eigler
2014-08-28 13:31                               ` Gary Benson
2014-08-20 15:32               ` Mike Frysinger [this message]
2014-08-20 19:14                 ` [PATCH 4/5 v7] Introduce common-debug.h Gary Benson
2014-08-21  1:18                   ` Mike Frysinger
2014-08-13  9:56 ` [PATCH 3/5 v7] Move print-utils.h to common-defs.h Gary Benson
2014-08-18 16:29   ` Doug Evans
2014-08-13  9:56 ` [PATCH 2/5 v7] Introduce common-types.h Gary Benson
2014-08-18 16:25   ` Doug Evans
2014-08-13 10:34 ` [PATCH 5/5 v7] Introduce show_debug_regs Gary Benson
2014-08-18 16:40   ` Doug Evans
2014-08-13 10:55 ` [PATCH 1/5 v7] Introduce common/errors.h Gary Benson
2014-08-18 16:20   ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2738453.Usiax8h3c8@vapier \
    --to=vapier@gentoo.org \
    --cc=dje@google.com \
    --cc=fche@redhat.com \
    --cc=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=sellcey@mips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox