[PING PATCH] Rename SIM's debug_printf (Was: [PATCH 4/5 v7] Introduce common-debug.h)

[Gary Benson <gbenson@redhat.com>]

Mike Frysinger wrote:
> On Wed 20 Aug 2014 18:47:41 Frank Ch. Eigler wrote:
> > > > (I have no objection to the #define in gdb/*.)
> > > 
> > > I take this to mean you do object to a #define in sim/*.
> > 
> > No - just that a gdb/* patch the only one I think I saw.  Making
> > an analogue for sim/* would be fine, but testing it for wide
> > buildability will be a hassle.
> 
> i wouldn't worry too much about that ... i have local builds for
> most every target, and i think some others notice when things break
> too

Frank, are you ok with the patch in sim/* with Mike's assurances?
I inlined the patch under discussion below, for avoidance of doubt.

Thanks,
Gary

-- 
2014-08-20  Gary Benson  <gbenson@redhat.com>

	* sim-trace.h (debug_printf): New define.

diff --git a/sim/common/sim-trace.h b/sim/common/sim-trace.h
index 5fb58e1..69fffb4 100644
--- a/sim/common/sim-trace.h
+++ b/sim/common/sim-trace.h
@@ -583,6 +583,9 @@ extern void trace_vprintf (SIM_DESC, sim_cpu *, const char *, va_list);
 /* Non-zero if "--debug-insn" specified.  */
 #define DEBUG_INSN_P(cpu) DEBUG_P (cpu, DEBUG_INSN_IDX)
 
+/* GDB also has a debug_printf, so we shadow ours.  */
+#define debug_printf sim_debug_printf
+
 extern void debug_printf (sim_cpu *, const char *, ...)
      __attribute__((format (printf, 2, 3)));