From: Doug Evans <dje@google.com>
To: Gary Benson <gbenson@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>,
Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH 1/5 v7] Introduce common/errors.h
Date: Mon, 18 Aug 2014 16:20:00 -0000 [thread overview]
Message-ID: <CADPb22SRXWqMC8g4wUAiVD7n_LCyG-RK07CfAJNiKOED=YfvLg@mail.gmail.com> (raw)
In-Reply-To: <1407923779-22149-2-git-send-email-gbenson@redhat.com>
On Wed, Aug 13, 2014 at 2:56 AM, Gary Benson <gbenson@redhat.com> wrote:
> This introduces common/errors.h. This holds some error- and warning-
> related declarations that can be used by the code in common, nat and
> target. Some of the declared functions must be provided by the client
> as documented by the header file comments.
>
> gdb/
> 2014-08-13 Tom Tromey <tromey@redhat.com>
> Gary Benson <gbenson@redhat.com>
>
> * common/errors.h: New file.
> * common/errors.c: Likewise.
> * Makefile.in (SFILES): Add common/errors.c.
> (HFILES_NO_SRCDIR): Add common/errors.h.
> (COMMON_OBS): Add errors.o.
> (errors.o): New rule.
> * common/common-defs.h: Include errors.h.
> * utils.h (perror_with_name, error, verror, warning, vwarning):
> Don't declare.
> * common/common-utils.h: (malloc_failure, internal_error):
> Likewise.
>
> gdb/gdbserver/
> 2014-08-13 Tom Tromey <tromey@redhat.com>
> Gary Benson <gbenson@redhat.com>
>
> * Makefile.in (SFILES): Add common/errors.c.
> (OBS): Add errors.o.
> (IPA_OBS): Add errors-ipa.o.
> (errors.o): New rule.
> (errors-ipa.o): Likewise.
> * utils.h (perror_with_name, error, warning): Don't declare.
> * utils.c (warning): Renamed and rewritten as...
> (vwarning): New function.
> (error): Renamed and rewritten as...
> (verror): New function.
> (internal_error): Renamed and rewritten as...
> (internal_verror): New function.
LGTM
prev parent reply other threads:[~2014-08-18 16:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 9:56 [PATCH 0/5 v7] Common code cleanups (first four, and one new) Gary Benson
2014-08-13 9:56 ` [PATCH 2/5 v7] Introduce common-types.h Gary Benson
2014-08-18 16:25 ` Doug Evans
2014-08-13 9:56 ` [PATCH 4/5 v7] Introduce common-debug.h Gary Benson
2014-08-18 16:38 ` Doug Evans
2014-08-19 9:12 ` Gary Benson
2014-08-19 23:22 ` Steve Ellcey
2014-08-20 8:53 ` Gary Benson
2014-08-20 9:42 ` Mike Frysinger
2014-08-20 12:09 ` Gary Benson
2014-08-20 13:32 ` Frank Ch. Eigler
2014-08-20 19:16 ` Gary Benson
2014-08-20 21:41 ` Frank Ch. Eigler
2014-08-20 21:58 ` Doug Evans
2014-08-20 21:58 ` Gary Benson
2014-08-20 22:48 ` Frank Ch. Eigler
2014-08-21 1:19 ` Mike Frysinger
2014-08-27 8:53 ` [PING PATCH] Rename SIM's debug_printf (Was: [PATCH 4/5 v7] Introduce common-debug.h) Gary Benson
2014-08-28 0:09 ` Frank Ch. Eigler
2014-08-28 13:31 ` Gary Benson
2014-08-20 15:32 ` [PATCH 4/5 v7] Introduce common-debug.h Mike Frysinger
2014-08-20 19:14 ` Gary Benson
2014-08-21 1:18 ` Mike Frysinger
2014-08-13 9:56 ` [PATCH 3/5 v7] Move print-utils.h to common-defs.h Gary Benson
2014-08-18 16:29 ` Doug Evans
2014-08-13 10:34 ` [PATCH 5/5 v7] Introduce show_debug_regs Gary Benson
2014-08-18 16:40 ` Doug Evans
2014-08-13 10:55 ` [PATCH 1/5 v7] Introduce common/errors.h Gary Benson
2014-08-18 16:20 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22SRXWqMC8g4wUAiVD7n_LCyG-RK07CfAJNiKOED=YfvLg@mail.gmail.com' \
--to=dje@google.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox