From: Steve Ellcey <sellcey@mips.com>
To: Gary Benson <gbenson@redhat.com>
Cc: Doug Evans <dje@google.com>,
gdb-patches <gdb-patches@sourceware.org>,
Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH 4/5 v7] Introduce common-debug.h
Date: Tue, 19 Aug 2014 23:22:00 -0000 [thread overview]
Message-ID: <1408490530.31355.15.camel@ubuntu-sellcey> (raw)
In-Reply-To: <20140819091220.GB6493@blade.nx>
On Tue, 2014-08-19 at 10:12 +0100, Gary Benson wrote:
> > > 2014-08-13 Tom Tromey <tromey@redhat.com>
> > > Gary Benson <gbenson@redhat.com>
> > >
> > > * common/common-debug.h: New file.
> > > * common/common-debug.c: Likewise.
> > > * debug.c: Likewise.
> > > * Makefile.in (SFILES): Add common/common-debug.c.
> > > (HFILES_NO_SRCDIR): Add common/common-debug.h.
> > > (COMMON_OBS): Add common-debug.o and debug.o.
> > > (common-debug.o): New rule.
> > > * common/common-defs.h: Include common-debug.h.
> > > * common/agent.c (debug_agent_printf): New function.
> > > (DEBUG_AGENT): Redefine.
> > > * nat/i386-dregs.c (debug_printf): Undefine.
I just built gdb for mips (mips-linux-gnu and mips-mti-linux-gnu) and it
died with:
/local/home/sellcey/gcc/non_mti_linux/src/binutils-gdb/sim/mips/../common/sim-trace.c:1326: multiple definition of `debug_printf'
common-debug.o:/local/home/sellcey/gcc/non_mti_linux/src/binutils-gdb/gdb/common/common-debug.c:31: first defined here
collect2: ld returned 1 exit status
make[1]: *** [gdb] Error 1
I am assuming it has something to do with this patch.
Steve Ellcey
sellcey@mips.com
next prev parent reply other threads:[~2014-08-19 23:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 9:56 [PATCH 0/5 v7] Common code cleanups (first four, and one new) Gary Benson
2014-08-13 9:56 ` [PATCH 4/5 v7] Introduce common-debug.h Gary Benson
2014-08-18 16:38 ` Doug Evans
2014-08-19 9:12 ` Gary Benson
2014-08-19 23:22 ` Steve Ellcey [this message]
2014-08-20 8:53 ` Gary Benson
2014-08-20 9:42 ` Mike Frysinger
2014-08-20 12:09 ` Gary Benson
2014-08-20 13:32 ` Frank Ch. Eigler
2014-08-20 19:16 ` Gary Benson
2014-08-20 21:41 ` Frank Ch. Eigler
2014-08-20 21:58 ` Gary Benson
2014-08-20 22:48 ` Frank Ch. Eigler
2014-08-21 1:19 ` Mike Frysinger
2014-08-27 8:53 ` [PING PATCH] Rename SIM's debug_printf (Was: [PATCH 4/5 v7] Introduce common-debug.h) Gary Benson
2014-08-28 0:09 ` Frank Ch. Eigler
2014-08-28 13:31 ` Gary Benson
2014-08-20 21:58 ` [PATCH 4/5 v7] Introduce common-debug.h Doug Evans
2014-08-20 15:32 ` Mike Frysinger
2014-08-20 19:14 ` Gary Benson
2014-08-21 1:18 ` Mike Frysinger
2014-08-13 9:56 ` [PATCH 3/5 v7] Move print-utils.h to common-defs.h Gary Benson
2014-08-18 16:29 ` Doug Evans
2014-08-13 9:56 ` [PATCH 2/5 v7] Introduce common-types.h Gary Benson
2014-08-18 16:25 ` Doug Evans
2014-08-13 10:34 ` [PATCH 5/5 v7] Introduce show_debug_regs Gary Benson
2014-08-18 16:40 ` Doug Evans
2014-08-13 10:55 ` [PATCH 1/5 v7] Introduce common/errors.h Gary Benson
2014-08-18 16:20 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408490530.31355.15.camel@ubuntu-sellcey \
--to=sellcey@mips.com \
--cc=dje@google.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox