From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-115105-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11979 invoked by alias); 19 Aug 2014 23:22:25 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 11965 invoked by uid 89); 19 Aug 2014 23:22:24 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mailapp01.imgtec.com
Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Aug 2014 23:22:22 +0000
Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35])	by Websense Email Security Gateway with ESMTPS id 8F573852DC708;	Wed, 20 Aug 2014 00:22:14 +0100 (IST)
Received: from BAMAIL02.ba.imgtec.org (192.168.66.28) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 20 Aug 2014 00:22:18 +0100
Received: from [192.168.65.53] (192.168.65.53) by bamail02.ba.imgtec.org (192.168.66.28) with Microsoft SMTP Server (TLS) id 14.3.174.1; Tue, 19 Aug 2014 16:22:10 -0700
Message-ID: <1408490530.31355.15.camel@ubuntu-sellcey>
Subject: Re: [PATCH 4/5 v7] Introduce common-debug.h
From: Steve Ellcey <sellcey@mips.com>
To: Gary Benson <gbenson@redhat.com>
CC: Doug Evans <dje@google.com>, gdb-patches <gdb-patches@sourceware.org>,	Pedro Alves <palves@redhat.com>
Date: Tue, 19 Aug 2014 23:22:00 -0000
In-Reply-To: <20140819091220.GB6493@blade.nx>
References: <20140819091220.GB6493@blade.nx>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-SW-Source: 2014-08/txt/msg00370.txt.bz2

On Tue, 2014-08-19 at 10:12 +0100, Gary Benson wrote:

> > > 2014-08-13  Tom Tromey  <tromey@redhat.com>
> > >             Gary Benson  <gbenson@redhat.com>
> > >
> > >         * common/common-debug.h: New file.
> > >         * common/common-debug.c: Likewise.
> > >         * debug.c: Likewise.
> > >         * Makefile.in (SFILES): Add common/common-debug.c.
> > >         (HFILES_NO_SRCDIR): Add common/common-debug.h.
> > >         (COMMON_OBS): Add common-debug.o and debug.o.
> > >         (common-debug.o): New rule.
> > >         * common/common-defs.h: Include common-debug.h.
> > >         * common/agent.c (debug_agent_printf): New function.
> > >         (DEBUG_AGENT): Redefine.
> > >         * nat/i386-dregs.c (debug_printf): Undefine.

I just built gdb for mips (mips-linux-gnu and mips-mti-linux-gnu) and it
died with:

/local/home/sellcey/gcc/non_mti_linux/src/binutils-gdb/sim/mips/../common/sim-trace.c:1326: multiple definition of `debug_printf'
common-debug.o:/local/home/sellcey/gcc/non_mti_linux/src/binutils-gdb/gdb/common/common-debug.c:31: first defined here
collect2: ld returned 1 exit status
make[1]: *** [gdb] Error 1

I am assuming it has something to do with this patch.

Steve Ellcey
sellcey@mips.com