Re: [PATCH 4/5 v7] Introduce common-debug.h

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1514 bytes --]

On Wed 20 Aug 2014 20:14:37 Gary Benson wrote:
> Mike Frysinger wrote:
> > On Wed 20 Aug 2014 13:09:34 Gary Benson wrote:
> > > Mike Frysinger wrote:
> > > > On Wed 20 Aug 2014 09:52:43 Gary Benson wrote:
> > > > > Steve, you can probably work around this for now by adding:
> > > > >   #define debug_printf gdb_debug_printf
> > > > > 
> > > > > at the top of GDB's common/common-debug.h.  If SIM's debug_printf
> > > > > cannot be removed then maybe we will have to add some hack like
> > > > > this to GDB permanently.
> > > > 
> > > > i'm fine with updating sim/common/sim-trace.h with that idea:
> > > > #define debug_printf sim_debug_printf
> > > > 
> > > > all the symbols coming out of the sim really should be namespaced
> > > 
> > > Great.  I can put together a patch if you like (or I can make the
> > > change, or you can... whatever's easiest!)  I don't know much about
> > > SIM... is there a list to mail patches to?  And, is its upstream
> > > repo the same as binutils+GDB or is it imported from somewhere else
> > > like libiberty?
> > 
> > it would be great if you could put together the patch :).  sim
> > patches go to the same place as gdb (same repo), and i can approve
> > them when i see them.
> 
> Inlined below.  I'm away til Tuesday now, but I'll try and check my
> email before I go so if I see you and Frank are happy with this then
> I'll commit it.  If I don't, feel free to commit it yourself or wait
> (I'm happy with either).

lgtm.  thanks!
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]