From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23640 invoked by alias); 21 Aug 2014 01:18:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23628 invoked by uid 89); 21 Aug 2014 01:18:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 Aug 2014 01:17:59 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id BB5883402AB; Thu, 21 Aug 2014 01:17:57 +0000 (UTC) From: Mike Frysinger To: Gary Benson Cc: Steve Ellcey , Doug Evans , gdb-patches , Pedro Alves , "Frank Ch. Eigler" Subject: Re: [PATCH 4/5 v7] Introduce common-debug.h Date: Thu, 21 Aug 2014 01:18:00 -0000 Message-ID: <14691995.UsGn0kiTcN@vapier> User-Agent: KMail/4.13.3 (Linux/3.14.2; KDE/4.13.3; x86_64; ; ) In-Reply-To: <20140820191437.GB23764@blade.nx> References: <20140819091220.GB6493@blade.nx> <2738453.Usiax8h3c8@vapier> <20140820191437.GB23764@blade.nx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2814056.0hQdQcFMTu"; micalg="pgp-sha1"; protocol="application/pgp-signature" X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00456.txt.bz2 --nextPart2814056.0hQdQcFMTu Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" Content-length: 1495 On Wed 20 Aug 2014 20:14:37 Gary Benson wrote: > Mike Frysinger wrote: > > On Wed 20 Aug 2014 13:09:34 Gary Benson wrote: > > > Mike Frysinger wrote: > > > > On Wed 20 Aug 2014 09:52:43 Gary Benson wrote: > > > > > Steve, you can probably work around this for now by adding: > > > > > #define debug_printf gdb_debug_printf > > > > >=20 > > > > > at the top of GDB's common/common-debug.h. If SIM's debug_printf > > > > > cannot be removed then maybe we will have to add some hack like > > > > > this to GDB permanently. > > > >=20 > > > > i'm fine with updating sim/common/sim-trace.h with that idea: > > > > #define debug_printf sim_debug_printf > > > >=20 > > > > all the symbols coming out of the sim really should be namespaced > > >=20 > > > Great. I can put together a patch if you like (or I can make the > > > change, or you can... whatever's easiest!) I don't know much about > > > SIM... is there a list to mail patches to? And, is its upstream > > > repo the same as binutils+GDB or is it imported from somewhere else > > > like libiberty? > >=20 > > it would be great if you could put together the patch :). sim > > patches go to the same place as gdb (same repo), and i can approve > > them when i see them. >=20 > Inlined below. I'm away til Tuesday now, but I'll try and check my > email before I go so if I see you and Frank are happy with this then > I'll commit it. If I don't, feel free to commit it yourself or wait > (I'm happy with either). lgtm. thanks! -mike= --nextPart2814056.0hQdQcFMTu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABAgAGBQJT9UjKAAoJEEFjO5/oN/WB26wP/jMp6sW6NgioezPJhro0ppnt 5XIqwPiI+yxEqKnxXe2AxbY+COtjqiOcMfCE4/SE34eNMFnIYu1hWxkBE4HjoDf7 Si7Vkj+DAkZqqxEQloYXksI7Jmf3AkHm6NooPRwGsyqwOOn3Qq/aPcvfNnnAYiQP BvlqAfa+EMhx044uxNiJnEbU2XQqOIB/EEUxql3/9D6IAetkiDXi46/9wEJbKnaa BpX7BokGXe50uo+RIOoXzAVERGj0llJrOdoK7I2JMH/P4zaCgw/i5uIFr3+keGlY KMgXnigMqL6weIoMDwnZx5aBDMyFvSORVqC11d6t5s943bVnROBnYfyJAL1atY77 BTjsmSIVtyXVYhk6Zk534jgc2djqmuVZnropwcxEthQ/aKSYhgAkIX3alQ7SHJUg de08gt5dbQsABaCjOs5H0RWLxueAkIAAusZS7q6gH84K8tkzUfN8a7OyFky9C5wk SDX3/tgnq1QtdwxpwRjVBxXIuQ+SHan4q1F7xeYD3XeJUAr0SVJtzkF8GJ2TyH47 KHmVWUM8Pffj4YfD+oqxfBhPfOG8M6+SvX8sXN5jFQk6qEC2gzZYJTdul4/P5iog CSe/jYuDj0zNrIogAKEgfur548gnvm/XEXGMiH20o0WITYMH8TTzp/4mRe30XzHY 2Dah5tdzeSuNpjJmjS73 =kkyI -----END PGP SIGNATURE----- --nextPart2814056.0hQdQcFMTu--