From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3882 invoked by alias); 18 Aug 2014 16:20:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3868 invoked by uid 89); 18 Aug 2014 16:20:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f182.google.com Received: from mail-vc0-f182.google.com (HELO mail-vc0-f182.google.com) (209.85.220.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 18 Aug 2014 16:20:45 +0000 Received: by mail-vc0-f182.google.com with SMTP id hy4so5909943vcb.41 for ; Mon, 18 Aug 2014 09:20:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=f5hktx924ONITBjVRJ9JOnBXo9y42F0j3k9zXwH0CyM=; b=C5yLRtt35fQhX0TBf8K2hxTcQk5fH61o0ufM+taNX3of4Uru4VJ48Jbt6/eLOHSDkp JCQW+N+saO4QNzUw/41o2as2gw5RwFL2KE+AXWJQPLPxw1XN7v7MMm1ZNvuwDcpeVY8l li97C/yyrhqUdl8sFY1m9if70OFTqNCqoKpvQ91Dh2IQG/znMi41Seciiik4ySCjbQn3 CyGotdvy8xlSM6wlXaTNN+QiYl+3awuRz2AVldFcUFer2G+aX2T9S+Hn4/QVTsOc7INR K8s1eeyaTQSGLzImtAuS2SAf2EmsMUD1iK72IyuuWkQWZZneD25lNF6aEsdZ4tvogoYA V1Ag== X-Gm-Message-State: ALoCoQlLShmPmBx3UL0Iw8BCr73BG3QgY9p0MSmmPrrZBpHl3sWp/nBr+xdKkLD1FwmeI+1TvLzq MIME-Version: 1.0 X-Received: by 10.221.41.135 with SMTP id tu7mr508901vcb.70.1408378842878; Mon, 18 Aug 2014 09:20:42 -0700 (PDT) Received: by 10.52.136.203 with HTTP; Mon, 18 Aug 2014 09:20:42 -0700 (PDT) In-Reply-To: <1407923779-22149-2-git-send-email-gbenson@redhat.com> References: <1407923779-22149-1-git-send-email-gbenson@redhat.com> <1407923779-22149-2-git-send-email-gbenson@redhat.com> Date: Mon, 18 Aug 2014 16:20:00 -0000 Message-ID: Subject: Re: [PATCH 1/5 v7] Introduce common/errors.h From: Doug Evans To: Gary Benson Cc: gdb-patches , Pedro Alves Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00304.txt.bz2 On Wed, Aug 13, 2014 at 2:56 AM, Gary Benson wrote: > This introduces common/errors.h. This holds some error- and warning- > related declarations that can be used by the code in common, nat and > target. Some of the declared functions must be provided by the client > as documented by the header file comments. > > gdb/ > 2014-08-13 Tom Tromey > Gary Benson > > * common/errors.h: New file. > * common/errors.c: Likewise. > * Makefile.in (SFILES): Add common/errors.c. > (HFILES_NO_SRCDIR): Add common/errors.h. > (COMMON_OBS): Add errors.o. > (errors.o): New rule. > * common/common-defs.h: Include errors.h. > * utils.h (perror_with_name, error, verror, warning, vwarning): > Don't declare. > * common/common-utils.h: (malloc_failure, internal_error): > Likewise. > > gdb/gdbserver/ > 2014-08-13 Tom Tromey > Gary Benson > > * Makefile.in (SFILES): Add common/errors.c. > (OBS): Add errors.o. > (IPA_OBS): Add errors-ipa.o. > (errors.o): New rule. > (errors-ipa.o): Likewise. > * utils.h (perror_with_name, error, warning): Don't declare. > * utils.c (warning): Renamed and rewritten as... > (vwarning): New function. > (error): Renamed and rewritten as... > (verror): New function. > (internal_error): Renamed and rewritten as... > (internal_verror): New function. LGTM