From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16004 invoked by alias); 27 Aug 2014 08:53:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15994 invoked by uid 89); 27 Aug 2014 08:53:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 27 Aug 2014 08:53:27 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7R8rCcS015349 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Aug 2014 04:53:12 -0400 Received: from blade.nx (ovpn-116-90.ams2.redhat.com [10.36.116.90]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7R8rAF9027069; Wed, 27 Aug 2014 04:53:10 -0400 Received: by blade.nx (Postfix, from userid 1000) id A1A8F2640D7; Wed, 27 Aug 2014 09:53:09 +0100 (BST) Date: Wed, 27 Aug 2014 08:53:00 -0000 From: Gary Benson To: Mike Frysinger Cc: "Frank Ch. Eigler" , Steve Ellcey , Doug Evans , gdb-patches , Pedro Alves , Joel Sherrill Subject: [PING PATCH] Rename SIM's debug_printf (Was: [PATCH 4/5 v7] Introduce common-debug.h) Message-ID: <20140827085309.GC4533@blade.nx> References: <20140819091220.GB6493@blade.nx> <20140820215800.GA26899@blade.nx> <20140820224741.GE5363@redhat.com> <2362980.Wvr8be2HuO@vapier> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2362980.Wvr8be2HuO@vapier> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00548.txt.bz2 Mike Frysinger wrote: > On Wed 20 Aug 2014 18:47:41 Frank Ch. Eigler wrote: > > > > (I have no objection to the #define in gdb/*.) > > > > > > I take this to mean you do object to a #define in sim/*. > > > > No - just that a gdb/* patch the only one I think I saw. Making > > an analogue for sim/* would be fine, but testing it for wide > > buildability will be a hassle. > > i wouldn't worry too much about that ... i have local builds for > most every target, and i think some others notice when things break > too Frank, are you ok with the patch in sim/* with Mike's assurances? I inlined the patch under discussion below, for avoidance of doubt. Thanks, Gary -- 2014-08-20 Gary Benson * sim-trace.h (debug_printf): New define. diff --git a/sim/common/sim-trace.h b/sim/common/sim-trace.h index 5fb58e1..69fffb4 100644 --- a/sim/common/sim-trace.h +++ b/sim/common/sim-trace.h @@ -583,6 +583,9 @@ extern void trace_vprintf (SIM_DESC, sim_cpu *, const char *, va_list); /* Non-zero if "--debug-insn" specified. */ #define DEBUG_INSN_P(cpu) DEBUG_P (cpu, DEBUG_INSN_IDX) +/* GDB also has a debug_printf, so we shadow ours. */ +#define debug_printf sim_debug_printf + extern void debug_printf (sim_cpu *, const char *, ...) __attribute__((format (printf, 2, 3)));