From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3944 invoked by alias); 20 Aug 2014 13:32:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3933 invoked by uid 89); 20 Aug 2014 13:32:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 Aug 2014 13:32:19 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KDW0mj023939 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Aug 2014 09:32:00 -0400 Received: from fche.csb (vpn-61-83.rdu2.redhat.com [10.10.61.83]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7KDVwt2011133; Wed, 20 Aug 2014 09:31:58 -0400 Received: by fche.csb (Postfix, from userid 2569) id BBD955850D; Wed, 20 Aug 2014 09:31:55 -0400 (EDT) Date: Wed, 20 Aug 2014 13:32:00 -0000 From: "Frank Ch. Eigler" To: Gary Benson Cc: Mike Frysinger , Steve Ellcey , Doug Evans , gdb-patches , Pedro Alves Subject: Re: [PATCH 4/5 v7] Introduce common-debug.h Message-ID: <20140820133155.GB5363@redhat.com> References: <20140819091220.GB6493@blade.nx> <1408490530.31355.15.camel@ubuntu-sellcey> <20140820085243.GA2694@blade.nx> <15329331.NicJ8HFAzI@vapier> <20140820120934.GA26854@blade.nx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140820120934.GA26854@blade.nx> User-Agent: Mutt/1.4.2.2i X-SW-Source: 2014-08/txt/msg00398.txt.bz2 Hi - > > [...] > > i'm fine with updating sim/common/sim-trace.h with that idea: > > #define debug_printf sim_debug_printf > > all the symbols coming out of the sim really should be namespaced IMHO, names this generic should be avoided in *both* application (gdb) and library (sim), lest another future library come & interfere later. > Great. I can put together a patch if you like (or I can make the > change, or you can... whatever's easiest!) I don't know much about > SIM... is there a list to mail patches to? And, is its upstream > repo the same as binutils+GDB or is it imported from somewhere else > like libiberty? sim is part of the binutils-gdb.git repo, patches here fine. The main problem with testing the sim for changes like this is its inability to easily build all targets, and its aggressive use of macros, which makes it hard to know you've actually covered all the cases for a symbol-rename. - FChE