* [RFA] stabsread.c (define_symbol): Guard against bad stabstring input.
@ 2011-03-05 0:37 Michael Snyder
2011-03-05 0:43 ` Pedro Alves
0 siblings, 1 reply; 6+ messages in thread
From: Michael Snyder @ 2011-03-05 0:37 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 74 bytes --]
I think I heard someone say that gdb should be proof against all inputs?
[-- Attachment #2: null13.txt --]
[-- Type: text/plain, Size: 690 bytes --]
2011-03-04 Michael Snyder <msnyder@vmware.com>
* stabsread.c (define_symbol): Guard against bad stabstring input.
Index: stabsread.c
===================================================================
RCS file: /cvs/src/src/gdb/stabsread.c,v
retrieving revision 1.136
diff -u -p -r1.136 stabsread.c
--- stabsread.c 28 Feb 2011 23:32:27 -0000 1.136
+++ stabsread.c 5 Mar 2011 00:34:13 -0000
@@ -636,6 +636,9 @@ define_symbol (CORE_ADDR valu, char *str
{
p += 2;
p = strchr (p, ':');
+ if (p == NULL)
+ internal_error (__FILE__, __LINE__,
+ _("Bad stabs string '%s'"), string);
}
/* If a nameless stab entry, all we need is the type, not the symbol.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFA] stabsread.c (define_symbol): Guard against bad stabstring input.
2011-03-05 0:37 [RFA] stabsread.c (define_symbol): Guard against bad stabstring input Michael Snyder
@ 2011-03-05 0:43 ` Pedro Alves
2011-03-05 0:49 ` Pedro Alves
0 siblings, 1 reply; 6+ messages in thread
From: Pedro Alves @ 2011-03-05 0:43 UTC (permalink / raw)
To: gdb-patches; +Cc: Michael Snyder
On Saturday 05 March 2011 00:37:25, Michael Snyder wrote:
> I think I heard someone say that gdb should be proof against all inputs?
Yes, but bad inputs aren't gdb bugs, so those should be errors
or warnings, not internal_errors.
--
Pedro Alves
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA] stabsread.c (define_symbol): Guard against bad stabstring input.
2011-03-05 0:43 ` Pedro Alves
@ 2011-03-05 0:49 ` Pedro Alves
2011-03-11 21:35 ` Michael Snyder
0 siblings, 1 reply; 6+ messages in thread
From: Pedro Alves @ 2011-03-05 0:49 UTC (permalink / raw)
To: gdb-patches; +Cc: Michael Snyder
On Saturday 05 March 2011 00:42:59, Pedro Alves wrote:
> On Saturday 05 March 2011 00:37:25, Michael Snyder wrote:
> > I think I heard someone say that gdb should be proof against all inputs?
>
> Yes, but bad inputs aren't gdb bugs, so those should be errors
> or warnings, not internal_errors.
for completeness: ... or "complaints", of which the symbol
readers are the biggest users, exactly to complain about
bad input debug info. complaints have the nice property
that they warn once, and go quiet the next time the problem
appears --- when we see a malformed debug info problem, we
tend to see a lot of instances of the same in the same run,
so that feature prevents terminal flooding with a bunch of
duplicated warnings.
--
Pedro Alves
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA] stabsread.c (define_symbol): Guard against bad stabstring input.
2011-03-05 0:49 ` Pedro Alves
@ 2011-03-11 21:35 ` Michael Snyder
2011-03-15 14:44 ` Pedro Alves
0 siblings, 1 reply; 6+ messages in thread
From: Michael Snyder @ 2011-03-11 21:35 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
Pedro Alves wrote:
> On Saturday 05 March 2011 00:42:59, Pedro Alves wrote:
>> On Saturday 05 March 2011 00:37:25, Michael Snyder wrote:
>>> I think I heard someone say that gdb should be proof against all inputs?
>> Yes, but bad inputs aren't gdb bugs, so those should be errors
>> or warnings, not internal_errors.
>
> for completeness: ... or "complaints", of which the symbol
> readers are the biggest users, exactly to complain about
> bad input debug info. complaints have the nice property
> that they warn once, and go quiet the next time the problem
> appears --- when we see a malformed debug info problem, we
> tend to see a lot of instances of the same in the same run,
> so that feature prevents terminal flooding with a bunch of
> duplicated warnings.
>
Thanks. How about this?
[-- Attachment #2: null13b.txt --]
[-- Type: text/plain, Size: 719 bytes --]
2011-03-04 Michael Snyder <msnyder@vmware.com>
* stabsread.c (define_symbol): Guard against bad stabstring input.
Index: stabsread.c
===================================================================
RCS file: /cvs/src/src/gdb/stabsread.c,v
retrieving revision 1.136
diff -u -p -r1.136 stabsread.c
--- stabsread.c 28 Feb 2011 23:32:27 -0000 1.136
+++ stabsread.c 11 Mar 2011 21:11:44 -0000
@@ -636,6 +636,12 @@ define_symbol (CORE_ADDR valu, char *str
{
p += 2;
p = strchr (p, ':');
+ if (p == NULL)
+ {
+ complaint (&symfile_complaints,
+ _("Bad stabs string '%s'"), string);
+ return NULL;
+ }
}
/* If a nameless stab entry, all we need is the type, not the symbol.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFA] stabsread.c (define_symbol): Guard against bad stabstring input.
2011-03-11 21:35 ` Michael Snyder
@ 2011-03-15 14:44 ` Pedro Alves
2011-03-15 18:07 ` Michael Snyder
0 siblings, 1 reply; 6+ messages in thread
From: Pedro Alves @ 2011-03-15 14:44 UTC (permalink / raw)
To: gdb-patches; +Cc: Michael Snyder
On Friday 11 March 2011 21:15:04, Michael Snyder wrote:
> Pedro Alves wrote:
> > On Saturday 05 March 2011 00:42:59, Pedro Alves wrote:
> >> On Saturday 05 March 2011 00:37:25, Michael Snyder wrote:
> >>> I think I heard someone say that gdb should be proof against all inputs?
> >> Yes, but bad inputs aren't gdb bugs, so those should be errors
> >> or warnings, not internal_errors.
> >
> > for completeness: ... or "complaints", of which the symbol
> > readers are the biggest users, exactly to complain about
> > bad input debug info. complaints have the nice property
> > that they warn once, and go quiet the next time the problem
> > appears --- when we see a malformed debug info problem, we
> > tend to see a lot of instances of the same in the same run,
> > so that feature prevents terminal flooding with a bunch of
> > duplicated warnings.
> >
>
> Thanks. How about this?
Sure, thanks.
--
Pedro Alves
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA] stabsread.c (define_symbol): Guard against bad stabstring input.
2011-03-15 14:44 ` Pedro Alves
@ 2011-03-15 18:07 ` Michael Snyder
0 siblings, 0 replies; 6+ messages in thread
From: Michael Snyder @ 2011-03-15 18:07 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches
Pedro Alves wrote:
> On Friday 11 March 2011 21:15:04, Michael Snyder wrote:
>> Pedro Alves wrote:
>>> On Saturday 05 March 2011 00:42:59, Pedro Alves wrote:
>>>> On Saturday 05 March 2011 00:37:25, Michael Snyder wrote:
>>>>> I think I heard someone say that gdb should be proof against all inputs?
>>>> Yes, but bad inputs aren't gdb bugs, so those should be errors
>>>> or warnings, not internal_errors.
>>> for completeness: ... or "complaints", of which the symbol
>>> readers are the biggest users, exactly to complain about
>>> bad input debug info. complaints have the nice property
>>> that they warn once, and go quiet the next time the problem
>>> appears --- when we see a malformed debug info problem, we
>>> tend to see a lot of instances of the same in the same run,
>>> so that feature prevents terminal flooding with a bunch of
>>> duplicated warnings.
>>>
>> Thanks. How about this?
>
> Sure, thanks.
Committed.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-15 17:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-05 0:37 [RFA] stabsread.c (define_symbol): Guard against bad stabstring input Michael Snyder
2011-03-05 0:43 ` Pedro Alves
2011-03-05 0:49 ` Pedro Alves
2011-03-11 21:35 ` Michael Snyder
2011-03-15 14:44 ` Pedro Alves
2011-03-15 18:07 ` Michael Snyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox