From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10128 invoked by alias); 15 Mar 2011 17:54:59 -0000 Received: (qmail 10036 invoked by uid 22791); 15 Mar 2011 17:54:56 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,KAM_STOCKTIP,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Mar 2011 17:54:49 +0000 Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 0CABC18007; Tue, 15 Mar 2011 10:54:47 -0700 (PDT) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost2.vmware.com (Postfix) with ESMTP id EFF688EEA9; Tue, 15 Mar 2011 10:54:46 -0700 (PDT) Message-ID: <4D7FA7E6.4030005@vmware.com> Date: Tue, 15 Mar 2011 18:07:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20110128) MIME-Version: 1.0 To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: Re: [RFA] stabsread.c (define_symbol): Guard against bad stabstring input. References: <4D7185C5.70505@vmware.com> <201103050049.14785.pedro@codesourcery.com> <4D7A90D8.8060903@vmware.com> <201103151425.01026.pedro@codesourcery.com> In-Reply-To: <201103151425.01026.pedro@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00802.txt.bz2 Pedro Alves wrote: > On Friday 11 March 2011 21:15:04, Michael Snyder wrote: >> Pedro Alves wrote: >>> On Saturday 05 March 2011 00:42:59, Pedro Alves wrote: >>>> On Saturday 05 March 2011 00:37:25, Michael Snyder wrote: >>>>> I think I heard someone say that gdb should be proof against all inputs? >>>> Yes, but bad inputs aren't gdb bugs, so those should be errors >>>> or warnings, not internal_errors. >>> for completeness: ... or "complaints", of which the symbol >>> readers are the biggest users, exactly to complain about >>> bad input debug info. complaints have the nice property >>> that they warn once, and go quiet the next time the problem >>> appears --- when we see a malformed debug info problem, we >>> tend to see a lot of instances of the same in the same run, >>> so that feature prevents terminal flooding with a bunch of >>> duplicated warnings. >>> >> Thanks. How about this? > > Sure, thanks. Committed.