From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4280 invoked by alias); 5 Mar 2011 00:37:35 -0000 Received: (qmail 4270 invoked by uid 22791); 5 Mar 2011 00:37:35 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,KAM_STOCKTIP,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 05 Mar 2011 00:37:26 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id AC05050007 for ; Fri, 4 Mar 2011 16:37:25 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost4.vmware.com (Postfix) with ESMTP id A206DCA069 for ; Fri, 4 Mar 2011 16:37:25 -0800 (PST) Message-ID: <4D7185C5.70505@vmware.com> Date: Sat, 05 Mar 2011 00:37:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [RFA] stabsread.c (define_symbol): Guard against bad stabstring input. Content-Type: multipart/mixed; boundary="------------000103080002030500060204" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00350.txt.bz2 This is a multi-part message in MIME format. --------------000103080002030500060204 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 74 I think I heard someone say that gdb should be proof against all inputs? --------------000103080002030500060204 Content-Type: text/plain; name="null13.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="null13.txt" Content-length: 690 2011-03-04 Michael Snyder * stabsread.c (define_symbol): Guard against bad stabstring input. Index: stabsread.c =================================================================== RCS file: /cvs/src/src/gdb/stabsread.c,v retrieving revision 1.136 diff -u -p -r1.136 stabsread.c --- stabsread.c 28 Feb 2011 23:32:27 -0000 1.136 +++ stabsread.c 5 Mar 2011 00:34:13 -0000 @@ -636,6 +636,9 @@ define_symbol (CORE_ADDR valu, char *str { p += 2; p = strchr (p, ':'); + if (p == NULL) + internal_error (__FILE__, __LINE__, + _("Bad stabs string '%s'"), string); } /* If a nameless stab entry, all we need is the type, not the symbol. --------------000103080002030500060204--