From: Michael Snyder <msnyder@vmware.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] stabsread.c (define_symbol): Guard against bad stabstring input.
Date: Tue, 15 Mar 2011 18:07:00 -0000 [thread overview]
Message-ID: <4D7FA7E6.4030005@vmware.com> (raw)
In-Reply-To: <201103151425.01026.pedro@codesourcery.com>
Pedro Alves wrote:
> On Friday 11 March 2011 21:15:04, Michael Snyder wrote:
>> Pedro Alves wrote:
>>> On Saturday 05 March 2011 00:42:59, Pedro Alves wrote:
>>>> On Saturday 05 March 2011 00:37:25, Michael Snyder wrote:
>>>>> I think I heard someone say that gdb should be proof against all inputs?
>>>> Yes, but bad inputs aren't gdb bugs, so those should be errors
>>>> or warnings, not internal_errors.
>>> for completeness: ... or "complaints", of which the symbol
>>> readers are the biggest users, exactly to complain about
>>> bad input debug info. complaints have the nice property
>>> that they warn once, and go quiet the next time the problem
>>> appears --- when we see a malformed debug info problem, we
>>> tend to see a lot of instances of the same in the same run,
>>> so that feature prevents terminal flooding with a bunch of
>>> duplicated warnings.
>>>
>> Thanks. How about this?
>
> Sure, thanks.
Committed.
prev parent reply other threads:[~2011-03-15 17:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-05 0:37 Michael Snyder
2011-03-05 0:43 ` Pedro Alves
2011-03-05 0:49 ` Pedro Alves
2011-03-11 21:35 ` Michael Snyder
2011-03-15 14:44 ` Pedro Alves
2011-03-15 18:07 ` Michael Snyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7FA7E6.4030005@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox